]> git.ipfire.org Git - thirdparty/openssh-portable.git/commitdiff
Skip hostbased during Valgrind tests.
authorDarren Tucker <dtucker@dtucker.net>
Thu, 11 Aug 2022 03:33:51 +0000 (13:33 +1000)
committerDarren Tucker <dtucker@dtucker.net>
Thu, 11 Aug 2022 03:50:05 +0000 (13:50 +1000)
Valgrind doesn't let ssh exec ssh-keysign (because it's setuid) so skip
it during the Valgrind based tests.

See https://bugs.kde.org/show_bug.cgi?id=119404 for a discussion of this
(ironically there the problematic binary was ssh(1) back when it could
still be setuid).

.github/configs

index 48070ee75309964b385805eeaeef0ede8412c0b2..a853c6329d9151d3f46ad2f79b7a6a38f8d966da 100755 (executable)
@@ -166,8 +166,9 @@ case "$config" in
        case "$config" in
            valgrind-1)
                # All tests except agent-timeout (which is flaky under valgrind)
-               #) and slow ones that run separately to increase parallelism.
-               SKIP_LTESTS="agent-timeout ${tests2} ${tests3} ${tests4}"
+               # and hostbased (since valgrind won't let ssh exec keysign).
+               # Slow ones are run separately to increase parallelism.
+               SKIP_LTESTS="agent-timeout hostbased ${tests2} ${tests3} ${tests4}"
                ;;
            valgrind-2)
                LTESTS="${tests2}"