]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
gpio: shared: ignore GPIO hogs when traversing the device tree
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Wed, 26 Nov 2025 16:49:06 +0000 (17:49 +0100)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Fri, 28 Nov 2025 08:29:14 +0000 (09:29 +0100)
GPIO hogs have a "gpios" property but it's not a phandle to a remote
node - it references the parent GPIO controller. We must not try to
parse it as a phandle.

Fixes: a060b8c511ab ("gpiolib: implement low-level, shared GPIO support")
Reported-by: Cosmin Tanislav <demonsingur@gmail.com>
Closes: https://lore.kernel.org/all/2d96e464-e17c-4ff5-9a08-b215b77da04f@gmail.com/
Link: https://lore.kernel.org/r/20251126-gpio-shared-fixes-v1-2-18309c0e87b5@linaro.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpiolib-shared.c

index 3a6d4cd54081efb11ac2b7d530a0f0a06f5a9412..cd4dd6fc76abf32e7a437c3c54eec807478170f9 100644 (file)
@@ -83,6 +83,13 @@ static bool gpio_shared_of_node_ignore(struct device_node *node)
        if (of_node_name_eq(node, "__symbols__"))
                return true;
 
+       /*
+        * GPIO hogs have a "gpios" property which is not a phandle and can't
+        * possibly refer to a shared GPIO.
+        */
+       if (of_property_present(node, "gpio-hog"))
+               return true;
+
        return false;
 }