]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: phy: microchip_t1s: move LAN867X reset handling to a new function
authorParthiban Veerasooran <parthiban.veerasooran@microchip.com>
Thu, 10 Oct 2024 08:22:02 +0000 (13:52 +0530)
committerJakub Kicinski <kuba@kernel.org>
Fri, 11 Oct 2024 22:54:39 +0000 (15:54 -0700)
Move LAN867X reset handling code to a new function called
lan867x_check_reset_complete() which will be useful for the next patch
which also uses the same code to handle the reset functionality.

Signed-off-by: Parthiban Veerasooran <parthiban.veerasooran@microchip.com>
Link: https://patch.msgid.link/20241010082205.221493-5-parthiban.veerasooran@microchip.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/microchip_t1s.c

index b21f5acb4468d176fcb26dff475eff1d9cb914c5..d9814a09a0266ca6ea657794d8c7b603b8b074ca 100644 (file)
@@ -266,7 +266,7 @@ static int lan865x_revb_config_init(struct phy_device *phydev)
        return 0;
 }
 
-static int lan867x_revb1_config_init(struct phy_device *phydev)
+static int lan867x_check_reset_complete(struct phy_device *phydev)
 {
        int err;
 
@@ -288,6 +288,17 @@ static int lan867x_revb1_config_init(struct phy_device *phydev)
                }
        }
 
+       return 0;
+}
+
+static int lan867x_revb1_config_init(struct phy_device *phydev)
+{
+       int err;
+
+       err = lan867x_check_reset_complete(phydev);
+       if (err)
+               return err;
+
        /* Reference to AN1699
         * https://ww1.microchip.com/downloads/aemDocuments/documents/AIS/ProductDocuments/SupportingCollateral/AN-LAN8670-1-2-config-60001699.pdf
         * AN1699 says Read, Modify, Write, but the Write is not required if the