]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu_driver: Resolve Coverity CONSTANT_EXPRESSION_RESULT
authorJohn Ferlan <jferlan@redhat.com>
Wed, 27 Aug 2014 13:14:16 +0000 (09:14 -0400)
committerEric Blake <eblake@redhat.com>
Wed, 16 Dec 2015 02:52:26 +0000 (19:52 -0700)
The call to virDomainSnapshotRedefinePrep() had a spurrious ! in front of
it which caused Coverity to complan that the expression is always false.

(cherry picked from commit 9d7254de430f7ef7a4c6a2a20718942369ce9d06)

src/qemu/qemu_driver.c

index c46226ad0d3036cf0620fea9c423b7ff53546739..9548542b9f78e7b57bc6458bf4fdaef1b1f22565 100644 (file)
@@ -13527,8 +13527,8 @@ qemuDomainSnapshotCreateXML(virDomainPtr domain,
     }
 
     if (redefine) {
-        if (!virDomainSnapshotRedefinePrep(domain, vm, &def, &snap,
-                                           &update_current, flags) < 0)
+        if (virDomainSnapshotRedefinePrep(domain, vm, &def, &snap,
+                                          &update_current, flags) < 0)
             goto cleanup;
     } else {
         /* Easiest way to clone inactive portion of vm->def is via