]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
rtc: rc5t619: Fix an ERR_PTR vs NULL check
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 7 Apr 2020 09:28:52 +0000 (12:28 +0300)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Wed, 15 Apr 2020 07:58:24 +0000 (09:58 +0200)
The devm_kzalloc() function returns NULL on error, it doesn't return
error pointers so this check doesn't work.

Fixes: 540d1e15393d ("rtc: rc5t619: Add Ricoh RC5T619 RTC driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20200407092852.GI68494@mwanda
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-rc5t619.c

index 24e386ecbc7ed718c362825a9591f07f34c19049..dd1a20977478efb734b4ea97a0134da8e2082b82 100644 (file)
@@ -356,10 +356,8 @@ static int rc5t619_rtc_probe(struct platform_device *pdev)
        int err;
 
        rtc = devm_kzalloc(dev, sizeof(*rtc), GFP_KERNEL);
-       if (IS_ERR(rtc)) {
-               err = PTR_ERR(rtc);
+       if (!rtc)
                return -ENOMEM;
-       }
 
        rtc->rn5t618 = rn5t618;