]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
virito-blk: drop duplicate check
authorGonglei <arei.gonglei@huawei.com>
Wed, 24 Jun 2015 09:29:24 +0000 (17:29 +0800)
committerStefan Hajnoczi <stefanha@redhat.com>
Wed, 24 Jun 2015 15:16:04 +0000 (16:16 +0100)
in_num = req->elem.in_num, and req->elem.in_num is
checked in line 489, so the check about in_num variable
is superflous, let's drop it.

Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Message-id: 1435138164-11728-1-git-send-email-arei.gonglei@huawei.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
hw/block/virtio-blk.c

index bbb1fc1877ad55e9b2242066c58f309e8941e015..6aefda4bf28be076af57ee72f22ddf75102c8b59 100644 (file)
@@ -499,8 +499,7 @@ void virtio_blk_handle_request(VirtIOBlockReq *req, MultiReqBuffer *mrb)
 
     iov_discard_front(&iov, &out_num, sizeof(req->out));
 
-    if (in_num < 1 ||
-        in_iov[in_num - 1].iov_len < sizeof(struct virtio_blk_inhdr)) {
+    if (in_iov[in_num - 1].iov_len < sizeof(struct virtio_blk_inhdr)) {
         error_report("virtio-blk request inhdr too short");
         exit(1);
     }