]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: au0828: Use USB API functions rather than constants
authorChen Ni <nichen@iscas.ac.cn>
Wed, 18 Jun 2025 06:14:30 +0000 (14:14 +0800)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Fri, 29 Aug 2025 09:04:01 +0000 (11:04 +0200)
Use the function usb_endpoint_dir_in() and usb_endpoint_type()
rather than constants.

The Coccinelle semantic patch is as follows:

@@ struct usb_endpoint_descriptor *epd; @@

- ((epd->bEndpointAddress & \(USB_ENDPOINT_DIR_MASK\|0x80\)) ==
-  \(USB_DIR_IN\|0x80\))
+ usb_endpoint_dir_in(epd)

@@ struct usb_endpoint_descriptor *epd; @@

- (epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\))
+ usb_endpoint_type(epd)
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/usb/au0828/au0828-video.c

index e5dff969ed57e5c214bdc4b522ca8beabfa9c1e8..fbaa542c8259ac007ed441280d06a2770e4134f4 100644 (file)
@@ -1921,9 +1921,8 @@ int au0828_analog_register(struct au0828_dev *dev,
        iface_desc = interface->cur_altsetting;
        for (i = 0; i < iface_desc->desc.bNumEndpoints; i++) {
                endpoint = &iface_desc->endpoint[i].desc;
-               if (((endpoint->bEndpointAddress & USB_ENDPOINT_DIR_MASK)
-                    == USB_DIR_IN) &&
-                   ((endpoint->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK)
+               if (usb_endpoint_dir_in(endpoint) &&
+                   (usb_endpoint_type(endpoint)
                     == USB_ENDPOINT_XFER_ISOC)) {
 
                        /* we find our isoc in endpoint */