]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
vfs: use RCU in ilookup
authorMateusz Guzik <mjguzik@gmail.com>
Mon, 15 Jul 2024 07:13:24 +0000 (09:13 +0200)
committerChristian Brauner <brauner@kernel.org>
Fri, 30 Aug 2024 06:22:36 +0000 (08:22 +0200)
A soft lockup in ilookup was reported when stress-testing a 512-way
system [1] (see [2] for full context) and it was verified that not
taking the lock shifts issues back to mm.

[1] https://lore.kernel.org/linux-mm/56865e57-c250-44da-9713-cf1404595bcc@amd.com/
[2] https://lore.kernel.org/linux-mm/d2841226-e27b-4d3d-a578-63587a3aa4f3@amd.com/

Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Link: https://lore.kernel.org/r/20240715071324.265879-1-mjguzik@gmail.com
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/inode.c

index 10c4619faeef8cb81d84a91ec2d982d5a1a51a5c..de0969d6009c61b8d6557d349ad5a23b433af70e 100644 (file)
@@ -1570,9 +1570,7 @@ struct inode *ilookup(struct super_block *sb, unsigned long ino)
        struct hlist_head *head = inode_hashtable + hash(sb, ino);
        struct inode *inode;
 again:
-       spin_lock(&inode_hash_lock);
-       inode = find_inode_fast(sb, head, ino, true);
-       spin_unlock(&inode_hash_lock);
+       inode = find_inode_fast(sb, head, ino, false);
 
        if (inode) {
                if (IS_ERR(inode))