gc: add tests for --cruft and friends

In 5b92477f89 (builtin/gc.c: conditionally avoid pruning objects via
loose, 2022-05-20) gc learned to respect '--cruft' and 'gc.cruftPacks'.
'--cruft' is exercised in t5329-pack-objects-cruft.sh, but in a way that
doesn't check whether a lone gc run generates these cruft packs.
'gc.cruftPacks' is never exercised.

Add some tests to exercise these options to gc in the gc test suite.

Signed-off-by: Emily Shaffer <emilyshaffer@google.com>
Signed-off-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/t/t6500-gc.sh b/t/t6500-gc.sh
index cd6c53360d206bef95cac3af0188c5eb3052e76c..928a522194f602819ae12b823fdab7cd0ec25f80 100755 (executable)
--- a/t/t6500-gc.sh
+++ b/t/t6500-gc.sh
@@ -202,6 +202,49 @@ test_expect_success 'one of gc.reflogExpire{Unreachable,}=never does not skip "e
        grep -E "^trace: (built-in|exec|run_command): git reflog expire --" trace.out
 '
 
+prepare_cruft_history () {
+       test_commit base &&
+
+       test_commit --no-tag foo &&
+       test_commit --no-tag bar &&
+       git reset HEAD^^
+}
+
+assert_cruft_packs () {
+       find .git/objects/pack -name "*.mtimes" >mtimes &&
+       sed -e 's/\.mtimes$/\.pack/g' mtimes >packs &&
+
+       test_file_not_empty packs &&
+       while read pack
+       do
+               test_path_is_file "$pack" || return 1
+       done <packs
+}
+
+test_expect_success 'gc --cruft generates a cruft pack' '
+       test_when_finished "rm -fr crufts" &&
+       git init crufts &&
+       (
+               cd crufts &&
+
+               prepare_cruft_history &&
+               git gc --cruft &&
+               assert_cruft_packs
+       )
+'
+
+test_expect_success 'gc.cruftPacks=true generates a cruft pack' '
+       test_when_finished "rm -fr crufts" &&
+       git init crufts &&
+       (
+               cd crufts &&
+
+               prepare_cruft_history &&
+               git -c gc.cruftPacks=true gc &&
+               assert_cruft_packs
+       )
+'
+
 run_and_wait_for_auto_gc () {
        # We read stdout from gc for the side effect of waiting until the
        # background gc process exits, closing its fd 9.  Furthermore, the