]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: dsa: b53: do not enable EEE on bcm63xx
authorJonas Gorski <jonas.gorski@gmail.com>
Mon, 2 Jun 2025 19:39:49 +0000 (21:39 +0200)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 5 Jun 2025 09:07:34 +0000 (11:07 +0200)
BCM63xx internal switches do not support EEE, but provide multiple RGMII
ports where external PHYs may be connected. If one of these PHYs are EEE
capable, we may try to enable EEE for the MACs, which then hangs the
system on access of the (non-existent) EEE registers.

Fix this by checking if the switch actually supports EEE before
attempting to configure it.

Fixes: 22256b0afb12 ("net: dsa: b53: Move EEE functions to b53")
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Tested-by: Álvaro Fernández Rojas <noltari@gmail.com>
Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
Link: https://patch.msgid.link/20250602193953.1010487-2-jonas.gorski@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/dsa/b53/b53_common.c

index 132683ed3abe6991859022fabb3d476b813b4946..8a6a370c85808381b10f39c3695ddafbd2b3d9a4 100644 (file)
@@ -2353,6 +2353,9 @@ int b53_eee_init(struct dsa_switch *ds, int port, struct phy_device *phy)
 {
        int ret;
 
+       if (!b53_support_eee(ds, port))
+               return 0;
+
        ret = phy_init_eee(phy, false);
        if (ret)
                return 0;
@@ -2367,7 +2370,7 @@ bool b53_support_eee(struct dsa_switch *ds, int port)
 {
        struct b53_device *dev = ds->priv;
 
-       return !is5325(dev) && !is5365(dev);
+       return !is5325(dev) && !is5365(dev) && !is63xx(dev);
 }
 EXPORT_SYMBOL(b53_support_eee);