]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
alloc_tag: use release_pages() in the cleanup path
authorSuren Baghdasaryan <surenb@google.com>
Mon, 15 Sep 2025 21:27:54 +0000 (14:27 -0700)
committerAndrew Morton <akpm@linux-foundation.org>
Sun, 21 Sep 2025 21:22:30 +0000 (14:22 -0700)
Patch series "Minor fixes for memory allocation profiling", v2.

Over the last couple months I gathered a few reports of minor issues in
memory allocation profiling which are addressed in this patchset.

This patch (of 2):

When bulk-freeing an array of pages use release_pages() instead of freeing
them page-by-page.

Link: https://lkml.kernel.org/r/20250915212756.3998938-1-surenb@google.com
Link: https://lkml.kernel.org/r/20250915212756.3998938-2-surenb@google.com
Signed-off-by: Suren Baghdasaryan <surenb@google.com>
Suggested-by: Andrew Morton <akpm@linux-foundation.org>
Suggested-by: Usama Arif <usamaarif642@gmail.com>
Acked-by: Shakeel Butt <shakeel.butt@linux.dev>
Acked-by: Usama Arif <usamaarif642@gmail.com>
Cc: David Wang <00107082@163.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Kent Overstreet <kent.overstreet@linux.dev>
Cc: Pasha Tatashin <pasha.tatashin@soleen.com>
Cc: Sourav Panda <souravpanda@google.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
lib/alloc_tag.c

index e9b33848700a860cf9dc96a20bf7ea288974cd72..715315f5d9bafcab98cf3635ed6b25a7ac28baaf 100644 (file)
@@ -438,9 +438,10 @@ static int vm_module_tags_populate(void)
                if (nr < more_pages ||
                    vmap_pages_range(phys_end, phys_end + (nr << PAGE_SHIFT), PAGE_KERNEL,
                                     next_page, PAGE_SHIFT) < 0) {
+                       release_pages_arg arg = { .pages = next_page };
+
                        /* Clean up and error out */
-                       for (int i = 0; i < nr; i++)
-                               __free_page(next_page[i]);
+                       release_pages(arg, nr);
                        return -ENOMEM;
                }
 
@@ -682,11 +683,10 @@ static int __init alloc_mod_tags_mem(void)
 
 static void __init free_mod_tags_mem(void)
 {
-       int i;
+       release_pages_arg arg = { .pages = vm_module_tags->pages };
 
        module_tags.start_addr = 0;
-       for (i = 0; i < vm_module_tags->nr_pages; i++)
-               __free_page(vm_module_tags->pages[i]);
+       release_pages(arg, vm_module_tags->nr_pages);
        kfree(vm_module_tags->pages);
        free_vm_area(vm_module_tags);
 }