]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ASoC: da7219: fix endianness issues
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Sat, 5 Jan 2019 02:02:46 +0000 (20:02 -0600)
committerMark Brown <broonie@kernel.org>
Mon, 7 Jan 2019 16:53:38 +0000 (16:53 +0000)
Reported by Sparse.

da7219.c:440:44: warning: cast to restricted __le16
da7219.c:461:13: warning: incorrect type in assignment (different base types)
da7219.c:461:13:    expected unsigned short [unsigned] [usertype] val
da7219.c:461:13:    got restricted __le16 [usertype] <noident>
da7219.c:1451:16: warning: incorrect type in assignment (different base types)
da7219.c:1451:16:    expected unsigned short [unsigned] [usertype] offset
da7219.c:1451:16:    got restricted __le16 [usertype] <noident>

da7219-aad.c:150:37: warning: incorrect type in assignment (different base types)
da7219-aad.c:150:37:    expected unsigned short [unsigned] [usertype] tonegen_freq_hptest
da7219-aad.c:150:37:    got restricted __le16 [usertype] <noident>
da7219-aad.c:157:37: warning: incorrect type in assignment (different base types)
da7219-aad.c:157:37:    expected unsigned short [unsigned] [usertype] tonegen_freq_hptest
da7219-aad.c:157:37:    got restricted __le16 [usertype] <noident>

Cc: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/da7219-aad.c
sound/soc/codecs/da7219.c

index 2c7d5088e6f2759aba90e469be2b3b8eb8b07dcb..e0964b20a3899392d1992b0ee0e7407779f9b59f 100644 (file)
@@ -117,7 +117,7 @@ static void da7219_aad_hptest_work(struct work_struct *work)
        struct snd_soc_dapm_context *dapm = snd_soc_component_get_dapm(component);
        struct da7219_priv *da7219 = snd_soc_component_get_drvdata(component);
 
-       u16 tonegen_freq_hptest;
+       __le16 tonegen_freq_hptest;
        u8 pll_srm_sts, pll_ctrl, gain_ramp_ctrl, accdet_cfg8;
        int report = 0, ret = 0;
 
index e46e9f4bc994681615b25066054d20867d3507cb..ce165047b9f936aefbb83aafe7a225982b908c61 100644 (file)
@@ -423,7 +423,7 @@ static int da7219_tonegen_freq_get(struct snd_kcontrol *kcontrol,
        struct soc_mixer_control *mixer_ctrl =
                (struct soc_mixer_control *) kcontrol->private_value;
        unsigned int reg = mixer_ctrl->reg;
-       u16 val;
+       __le16 val;
        int ret;
 
        mutex_lock(&da7219->ctrl_lock);
@@ -450,7 +450,7 @@ static int da7219_tonegen_freq_put(struct snd_kcontrol *kcontrol,
        struct soc_mixer_control *mixer_ctrl =
                (struct soc_mixer_control *) kcontrol->private_value;
        unsigned int reg = mixer_ctrl->reg;
-       u16 val;
+       __le16 val;
        int ret;
 
        /*
@@ -1396,7 +1396,7 @@ static int da7219_set_dai_tdm_slot(struct snd_soc_dai *dai,
        struct snd_soc_component *component = dai->component;
        struct da7219_priv *da7219 = snd_soc_component_get_drvdata(component);
        u8 dai_bclks_per_wclk;
-       u16 offset;
+       __le16 offset;
        u32 frame_size;
 
        /* No channels enabled so disable TDM, revert to 64-bit frames */