]> git.ipfire.org Git - thirdparty/git.git/commitdiff
merge-ort: do leave trace2 region even if checkout fails
authorJohannes Schindelin <johannes.schindelin@gmx.de>
Fri, 29 Jul 2022 17:12:07 +0000 (17:12 +0000)
committerJunio C Hamano <gitster@pobox.com>
Mon, 1 Aug 2022 02:24:27 +0000 (19:24 -0700)
In 557ac0350d9 (merge-ort: begin performance work; instrument with
trace2_region_* calls, 2021-01-23), we added Trace2 instrumentation, but
in the error path that returns early, we forgot to tell Trace2 that
we're leaving the region. Let's fix that.

Pointed-out-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Reviewed-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
merge-ort.c

index 52deb36594a4d7fa97facf1eb43e4342569de138..07f54e409fac2e63f730ae6e8635e48f702a680e 100644 (file)
@@ -4226,6 +4226,7 @@ void merge_switch_to_result(struct merge_options *opt,
                        /* failure to function */
                        result->clean = -1;
                        merge_finalize(opt, result);
+                       trace2_region_leave("merge", "checkout", opt->repo);
                        return;
                }
                trace2_region_leave("merge", "checkout", opt->repo);
@@ -4237,6 +4238,8 @@ void merge_switch_to_result(struct merge_options *opt,
                        opt->priv = NULL;
                        result->clean = -1;
                        merge_finalize(opt, result);
+                       trace2_region_leave("merge", "record_conflicted",
+                                           opt->repo);
                        return;
                }
                opt->priv = NULL;