t9801: replace test -f with test_path_is_file

Although `test -f` has the same functionality as test_path_is_file(), in
the case where test_path_is_file() fails, we get much better debugging
information.

Replace `test -f` with test_path_is_file so that future developers
will have a better experience debugging these test cases.

Signed-off-by: Shubham Verma <shubhunic@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/t/t9801-git-p4-branch.sh b/t/t9801-git-p4-branch.sh
index a3abd778f93164ed35d169d8cbb37d9ab82b628a..ebdba0bde843b52dc4314a524f4ba5015c46a497 100755 (executable)
--- a/t/t9801-git-p4-branch.sh
+++ b/t/t9801-git-p4-branch.sh
@@ -200,19 +200,19 @@ test_expect_success 'git p4 clone simple branches' '
                git p4 clone --dest=. --detect-branches //depot@all &&
                git log --all --graph --decorate --stat &&
                git reset --hard p4/depot/branch1 &&
-               test -f file1 &&
-               test -f file2 &&
-               test -f file3 &&
+               test_path_is_file file1 &&
+               test_path_is_file file2 &&
+               test_path_is_file file3 &&
                grep update file2 &&
                git reset --hard p4/depot/branch2 &&
-               test -f file1 &&
-               test -f file2 &&
+               test_path_is_file file1 &&
+               test_path_is_file file2 &&
                test ! -f file3 &&
                ! grep update file2 &&
                git reset --hard p4/depot/branch3 &&
-               test -f file1 &&
-               test -f file2 &&
-               test -f file3 &&
+               test_path_is_file file1 &&
+               test_path_is_file file2 &&
+               test_path_is_file file3 &&
                grep update file2 &&
                cd "$cli" &&
                cd branch1 &&
@@ -603,22 +603,22 @@ test_expect_success 'git p4 clone simple branches with base folder on server sid
                git p4 clone --dest=. --use-client-spec  --detect-branches //depot@all &&
                git log --all --graph --decorate --stat &&
                git reset --hard p4/depot/branch1 &&
-               test -f file1 &&
-               test -f file2 &&
-               test -f file3 &&
-               test -f sub_file1 &&
+               test_path_is_file file1 &&
+               test_path_is_file file2 &&
+               test_path_is_file file3 &&
+               test_path_is_file sub_file1 &&
                grep update file2 &&
                git reset --hard p4/depot/branch2 &&
-               test -f file1 &&
-               test -f file2 &&
+               test_path_is_file file1 &&
+               test_path_is_file file2 &&
                test ! -f file3 &&
-               test -f sub_file1 &&
+               test_path_is_file sub_file1 &&
                ! grep update file2 &&
                git reset --hard p4/depot/branch3 &&
-               test -f file1 &&
-               test -f file2 &&
-               test -f file3 &&
-               test -f sub_file1 &&
+               test_path_is_file file1 &&
+               test_path_is_file file2 &&
+               test_path_is_file file3 &&
+               test_path_is_file sub_file1 &&
                grep update file2 &&
                cd "$cli" &&
                cd branch1 &&