]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
wifi: wlcore: Remove unused wl12xx_cmd_start_fwlog
authorDr. David Alan Gilbert <linux@treblig.org>
Sun, 22 Jun 2025 23:26:38 +0000 (00:26 +0100)
committerJohannes Berg <johannes.berg@intel.com>
Tue, 24 Jun 2025 07:24:42 +0000 (09:24 +0200)
wl12xx_cmd_start_fwlog() was added in 2011 by
commit 95dac04f8813 ("wl12xx: Support routing FW logs to the host")
but has remained unused.

Remove it.

(I can see the 'stop' is used, and the 'config' is used, so I assume
the 'start' isn't normally needed).

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Link: https://patch.msgid.link/20250622232638.166283-1-linux@treblig.org
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/ti/wlcore/cmd.c
drivers/net/wireless/ti/wlcore/cmd.h

index cd8ad0fe59cc12782745892e4fa0e9f4f751c05d..fa3a3f71dd156271b29227ff2f5227a837f8169d 100644 (file)
@@ -1804,32 +1804,6 @@ out:
        return ret;
 }
 
-int wl12xx_cmd_start_fwlog(struct wl1271 *wl)
-{
-       struct wl12xx_cmd_start_fwlog *cmd;
-       int ret = 0;
-
-       wl1271_debug(DEBUG_CMD, "cmd start firmware logger");
-
-       cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
-       if (!cmd) {
-               ret = -ENOMEM;
-               goto out;
-       }
-
-       ret = wl1271_cmd_send(wl, CMD_START_FWLOGGER, cmd, sizeof(*cmd), 0);
-       if (ret < 0) {
-               wl1271_error("failed to send start firmware logger command");
-               goto out_free;
-       }
-
-out_free:
-       kfree(cmd);
-
-out:
-       return ret;
-}
-
 int wl12xx_cmd_stop_fwlog(struct wl1271 *wl)
 {
        struct wl12xx_cmd_stop_fwlog *cmd;
index 4c2f2608ef3bd1f4e4b31bb99f00c8460b21a4fa..d16afb35f9eea4d0fd28c4a6097300fd858eee45 100644 (file)
@@ -81,7 +81,6 @@ int wlcore_cmd_regdomain_config_locked(struct wl1271 *wl);
 int wlcore_cmd_generic_cfg(struct wl1271 *wl, struct wl12xx_vif *wlvif,
                           u8 feature, u8 enable, u8 value);
 int wl12xx_cmd_config_fwlog(struct wl1271 *wl);
-int wl12xx_cmd_start_fwlog(struct wl1271 *wl);
 int wl12xx_cmd_stop_fwlog(struct wl1271 *wl);
 int wl12xx_cmd_channel_switch(struct wl1271 *wl,
                              struct wl12xx_vif *wlvif,