]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_lock.c
authorStefan Metzmacher <metze@samba.org>
Tue, 6 Sep 2011 12:01:43 +0000 (14:01 +0200)
committerKarolin Seeger <kseeger@samba.org>
Wed, 12 Oct 2011 18:48:55 +0000 (20:48 +0200)
metze
(cherry picked from commit a358eee2d8670d4a1675e82562fa704fa45a71e6)

source3/smbd/smb2_lock.c

index fce3c7c8979ffe67288ededd6546e01d21ad08b5..28612aea8a68314257d178a387ee9de138b80c48 100644 (file)
@@ -58,8 +58,6 @@ NTSTATUS smbd_smb2_request_process_lock(struct smbd_smb2_request *req)
        const uint8_t *inhdr;
        const uint8_t *inbody;
        const int i = req->current_idx;
-       size_t expected_body_size = 0x30;
-       size_t body_size;
        uint32_t in_smbpid;
        uint16_t in_lock_count;
        uint64_t in_file_id_persistent;
@@ -68,19 +66,15 @@ NTSTATUS smbd_smb2_request_process_lock(struct smbd_smb2_request *req)
        struct tevent_req *subreq;
        const uint8_t *lock_buffer;
        uint16_t l;
+       NTSTATUS status;
 
-       inhdr = (const uint8_t *)req->in.vector[i+0].iov_base;
-       if (req->in.vector[i+1].iov_len != (expected_body_size & 0xFFFFFFFE)) {
-               return smbd_smb2_request_error(req, NT_STATUS_INVALID_PARAMETER);
+       status = smbd_smb2_request_verify_sizes(req, 0x30);
+       if (!NT_STATUS_IS_OK(status)) {
+               return smbd_smb2_request_error(req, status);
        }
-
+       inhdr = (const uint8_t *)req->in.vector[i+0].iov_base;
        inbody = (const uint8_t *)req->in.vector[i+1].iov_base;
 
-       body_size = SVAL(inbody, 0x00);
-       if (body_size != expected_body_size) {
-               return smbd_smb2_request_error(req, NT_STATUS_INVALID_PARAMETER);
-       }
-
        in_smbpid                       = IVAL(inhdr, SMB2_HDR_PID);
 
        in_lock_count                   = CVAL(inbody, 0x02);