global: Remove dead code

Found with clang static analyzer.

diff --git a/src/auth/db-dict.c b/src/auth/db-dict.c
index a4c3b53ce7b572727818b44d2241826201b0fd3e..89903f841f20d22832a45f969fd2744c87812109 100644 (file)
--- a/src/auth/db-dict.c
+++ b/src/auth/db-dict.c
@@ -176,7 +176,7 @@ static const char *parse_setting(const char *key, const char *value,
                field->value = p_strdup(ctx->conn->pool, value);
                return NULL;
        }
-       return t_strconcat("Unknown setting: ", key, NULL);
+       i_unreached();
 }
 
 static bool parse_section(const char *type, const char *name,

diff --git a/src/auth/db-ldap.c b/src/auth/db-ldap.c
index 311d5f5c7836db9387e2dfa676c276fe146bf918..c03fecaf4b00256f0ac2e264f63d641c51545ab4 100644 (file)
--- a/src/auth/db-ldap.c
+++ b/src/auth/db-ldap.c
@@ -1665,7 +1665,7 @@ db_ldap_field_ptr_expand(const char *data, void *context,
 
        suffix = strchr(t_strcut(data, ':'), '@');
        if ((ret = db_ldap_field_expand(data, ctx, &field_name, error_r)) <= 0)
-               return ret;
+               i_unreached();
        if (field_name[0] == '\0') {
                *value_r = "";
                return 1;

diff --git a/src/doveadm/dsync/dsync-mailbox-tree.c b/src/doveadm/dsync/dsync-mailbox-tree.c
index 71874a3243a0135286a041270460cdf91f97de0d..0be8341fb304e930c04c1b59a2041377c0e51a7e 100644 (file)
--- a/src/doveadm/dsync/dsync-mailbox-tree.c
+++ b/src/doveadm/dsync/dsync-mailbox-tree.c
@@ -522,5 +522,5 @@ dsync_mailbox_delete_type_to_string(enum dsync_mailbox_delete_type type)
        case DSYNC_MAILBOX_DELETE_TYPE_UNSUBSCRIBE:
                return "unsubscribe";
        }
-       return t_strdup_printf("unknown #%u", type);
+       i_unreached();
 }

diff --git a/src/lib-http/http-client-peer.c b/src/lib-http/http-client-peer.c
index 1de86455c12e31bb7a6a9d04ef40f1ce6f10e5d0..98d2ae8c533608f7cec49e935867d62bcad74f1b 100644 (file)
--- a/src/lib-http/http-client-peer.c
+++ b/src/lib-http/http-client-peer.c
@@ -97,7 +97,6 @@ int http_client_peer_addr_cmp
                return null_strcmp(peer1->a.un.path, peer2->a.un.path);
        }
        i_unreached();
-       return 0;
 }
 
 /*

diff --git a/src/lib-http/test-http-server-errors.c b/src/lib-http/test-http-server-errors.c
index 81db670d4d8c2a318dd9e40cca787508c53c5a21..6767ba3d95120a1f3a87a00ce371283290e5c034 100644 (file)
--- a/src/lib-http/test-http-server-errors.c
+++ b/src/lib-http/test-http-server-errors.c
@@ -726,7 +726,6 @@ static void
 test_server_timeout(void *context ATTR_UNUSED)
 {
        i_fatal("Server timed out");
-       io_loop_stop(ioloop);
 }
 
 static void

diff --git a/src/lib-ldap/ldap-connection.c b/src/lib-ldap/ldap-connection.c
index 546777849fa2d2a5ca7f5f4021136e626d70c563..4777354c0397878043f9e08e27e89361f445774d 100644 (file)
--- a/src/lib-ldap/ldap-connection.c
+++ b/src/lib-ldap/ldap-connection.c
@@ -402,7 +402,7 @@ ldap_connection_connect_parse(struct ldap_connection *conn,
        default:
                i_unreached();
        }
-       return LDAP_SUCCESS;
+       i_unreached();
 }
 
 static

diff --git a/src/lib-storage/index/imapc/imapc-list.c b/src/lib-storage/index/imapc/imapc-list.c
index 16fca00699b1dce5ea20fb4b5edac51910f998a5..653b53ed7d0cd4f54d4ca389855f933dc1869f59 100644 (file)
--- a/src/lib-storage/index/imapc/imapc-list.c
+++ b/src/lib-storage/index/imapc/imapc-list.c
@@ -475,7 +475,6 @@ imapc_list_get_temp_prefix(struct mailbox_list *_list, bool global)
        } else {
                i_panic("imapc: Can't return a temp prefix for '%s'",
                        _list->ns->prefix);
-               return NULL;
        }
 }
 

diff --git a/src/lib-storage/index/index-mail.c b/src/lib-storage/index/index-mail.c
index a6cadf7c83b8e4c33b34dc63e62a304787948a64..fae86d59d0adf2dba7497efbfbef7e11c536e1a4 100644 (file)
--- a/src/lib-storage/index/index-mail.c
+++ b/src/lib-storage/index/index-mail.c
@@ -1540,7 +1540,6 @@ int index_mail_get_special(struct mail *_mail,
                return 0;
        default:
                i_unreached();
-               return -1;
        }
 }
 

diff --git a/src/lib-storage/index/shared/shared-list.c b/src/lib-storage/index/shared/shared-list.c
index b0deb7b6408cd320d6a2b59cb99addfa63a6306c..38c70a411b1aca0eb748150193523cb151454ab3 100644 (file)
--- a/src/lib-storage/index/shared/shared-list.c
+++ b/src/lib-storage/index/shared/shared-list.c
@@ -82,7 +82,6 @@ shared_list_get_temp_prefix(struct mailbox_list *list, bool global ATTR_UNUSED)
 {
        i_panic("shared mailbox list: Can't return a temp prefix for '%s'",
                list->ns->prefix);
-       return NULL;
 }
 
 static const char *

diff --git a/src/lib-storage/mail-search-mime.c b/src/lib-storage/mail-search-mime.c
index 4a4b95607e0c3ebaae06a893370982f414593ff6..efd1cad58407618fe444217dd358e14b34ae50af 100644 (file)
--- a/src/lib-storage/mail-search-mime.c
+++ b/src/lib-storage/mail-search-mime.c
@@ -307,10 +307,8 @@ bool mail_search_mime_arg_one_equals(const struct mail_search_mime_arg *arg1,
        case SEARCH_MIME_DEPTH_MAX:
        case SEARCH_MIME_INDEX:
                return arg1->value.number == arg2->value.number;
-               break;
        }
        i_unreached();
-       return FALSE;
 }
 
 bool mail_search_mime_arg_equals(const struct mail_search_mime_arg *arg1,

diff --git a/src/lib-storage/mail-search.c b/src/lib-storage/mail-search.c
index 5af50d907abc6d1c598ac820396f1fafbed2d208..66db4c4cda1182dff2107febe5b93d121d0099da 100644 (file)
--- a/src/lib-storage/mail-search.c
+++ b/src/lib-storage/mail-search.c
@@ -665,7 +665,6 @@ bool mail_search_arg_one_equals(const struct mail_search_arg *arg1,
 
        }
        i_unreached();
-       return FALSE;
 }
 
 bool mail_search_arg_equals(const struct mail_search_arg *arg1,

diff --git a/src/lib/failures.c b/src/lib/failures.c
index 738828bef7daad0f3c817ae6e1e767292f4b28a2..f66933923576fa13fb20357e1db378bddcae18aa 100644 (file)
--- a/src/lib/failures.c
+++ b/src/lib/failures.c
@@ -290,7 +290,8 @@ void i_panic(const char *format, ...)
 
        va_start(args, format);
        fatal_handler(&ctx, format, args);
-       va_end(args);
+       i_unreached();
+       /*va_end(args);*/
 }
 
 void i_fatal(const char *format, ...)
@@ -304,7 +305,8 @@ void i_fatal(const char *format, ...)
 
        va_start(args, format);
        fatal_handler(&ctx, format, args);
-       va_end(args);
+       i_unreached();
+       /*va_end(args);*/
 }
 
 void i_fatal_status(int status, const char *format, ...)
@@ -318,7 +320,8 @@ void i_fatal_status(int status, const char *format, ...)
 
        va_start(args, format);
        fatal_handler(&ctx, format, args);
-       va_end(args);
+       i_unreached();
+       /*va_end(args);*/
 }
 
 void i_error(const char *format, ...)

diff --git a/src/lib/test-array.c b/src/lib/test-array.c
index da7225a94264968c13a13bfe5a61c5d7bc3500d0..52f2f6f80d905be5ca845062aec83821f1ee7373 100644 (file)
--- a/src/lib/test-array.c
+++ b/src/lib/test-array.c
@@ -306,7 +306,7 @@ enum fatal_test_state fatal_array(unsigned int stage)
                /* allocation big enough, but memory not initialised */
                useless_ptr = array_idx(&ad, 0);
                return FATAL_TEST_FAILURE;
-       } break;
+       }
 
        case 1: {
                ARRAY(double) ad;
@@ -315,7 +315,7 @@ enum fatal_test_state fatal_array(unsigned int stage)
                /* actual out of range address requested */
                useless_ptr = array_idx(&ad, 2);
                return FATAL_TEST_FAILURE;
-       } break;
+       }
 
        case 2: {
                ARRAY(double) ad;
@@ -325,7 +325,7 @@ enum fatal_test_state fatal_array(unsigned int stage)
                array_append(&as, tmps, 2);
                array_copy(&ad.arr, 1, &as.arr, 0, 4);
                return FATAL_TEST_FAILURE;
-       } break;
+       }
        }
        test_end();
        /* Forces the compiler to check the value of useless_ptr, so that it

diff --git a/src/master/main.c b/src/master/main.c
index cb19b68678ee1f4e907a0dcba11d5108d713f24d..cc9a169203e823283c88c9853a7fba7b6b756f7c 100644 (file)
--- a/src/master/main.c
+++ b/src/master/main.c
@@ -82,7 +82,7 @@ void process_exec(const char *cmd)
                                  argv[0]);
        if (strncmp(argv[0], PACKAGE, strlen(PACKAGE)) != 0)
                argv[0] = t_strconcat(PACKAGE"-", argv[0], NULL);
-       (void)execv_const(executable, argv);
+       execv_const(executable, argv);
 }
 
 int get_uidgid(const char *user, uid_t *uid_r, gid_t *gid_r,