]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: si470x: fix printk warnings with clang
authorMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Wed, 24 Nov 2021 11:24:38 +0000 (11:24 +0000)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 29 Nov 2021 12:23:14 +0000 (13:23 +0100)
Clang doesn't like "%hu" on macros:

drivers/media/radio/si470x/radio-si470x-i2c.c:414:4: error: format specifies type 'unsigned short' but the argument has type 'int' [-Werror,-Wformat]
drivers/media/radio/si470x/radio-si470x-i2c.c:417:4: error: format specifies type 'unsigned short' but the argument has type 'int' [-Werror,-Wformat]

Besides that, changeset cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]")
dropped recomendation of using %h.

So, just replace them with "%u".

Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/radio/si470x/radio-si470x-i2c.c
drivers/media/radio/si470x/radio-si470x-usb.c

index a972c0705ac79c9d90aa051610766d6b7becd872..7ea7c6326f53c65b3f4f63d54d5c8c262e2fce02 100644 (file)
@@ -410,10 +410,10 @@ static int si470x_i2c_probe(struct i2c_client *client)
                        radio->registers[DEVICEID], radio->registers[SI_CHIPID]);
        if ((radio->registers[SI_CHIPID] & SI_CHIPID_FIRMWARE) < RADIO_FW_VERSION) {
                dev_warn(&client->dev,
-                       "This driver is known to work with firmware version %hu,\n",
+                       "This driver is known to work with firmware version %u,\n",
                        RADIO_FW_VERSION);
                dev_warn(&client->dev,
-                       "but the device has firmware version %hu.\n",
+                       "but the device has firmware version %u.\n",
                        radio->registers[SI_CHIPID] & SI_CHIPID_FIRMWARE);
                version_warning = 1;
        }
index 3f8634a46573010e428ba0e61ae80004a90d55a4..1e70e6971fe4c05495ce3100d6bf36799b837e3b 100644 (file)
@@ -681,10 +681,10 @@ static int si470x_usb_driver_probe(struct usb_interface *intf,
                        radio->registers[DEVICEID], radio->registers[SI_CHIPID]);
        if ((radio->registers[SI_CHIPID] & SI_CHIPID_FIRMWARE) < RADIO_FW_VERSION) {
                dev_warn(&intf->dev,
-                       "This driver is known to work with firmware version %hu,\n",
+                       "This driver is known to work with firmware version %u,\n",
                        RADIO_FW_VERSION);
                dev_warn(&intf->dev,
-                       "but the device has firmware version %hu.\n",
+                       "but the device has firmware version %u.\n",
                        radio->registers[SI_CHIPID] & SI_CHIPID_FIRMWARE);
                version_warning = 1;
        }
@@ -698,10 +698,10 @@ static int si470x_usb_driver_probe(struct usb_interface *intf,
                        radio->software_version, radio->hardware_version);
        if (radio->hardware_version < RADIO_HW_VERSION) {
                dev_warn(&intf->dev,
-                       "This driver is known to work with hardware version %hu,\n",
+                       "This driver is known to work with hardware version %u,\n",
                        RADIO_HW_VERSION);
                dev_warn(&intf->dev,
-                       "but the device has hardware version %hu.\n",
+                       "but the device has hardware version %u.\n",
                        radio->hardware_version);
                version_warning = 1;
        }