]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ALSA: hda: cs35l56: Remove redundant call to hda_cs_dsp_control_remove()
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Tue, 13 Aug 2024 11:07:50 +0000 (12:07 +0100)
committerTakashi Iwai <tiwai@suse.de>
Tue, 13 Aug 2024 11:18:49 +0000 (13:18 +0200)
The driver doesn't create any ALSA controls for firmware controls, so it
shouldn't be calling hda_cs_dsp_control_remove().

commit 34e1b1bb7324 ("ALSA: hda: cs35l56: Stop creating ALSA controls for
firmware coefficients") removed the call to hda_cs_dsp_add_controls() but
didn't remove the call for destroying those controls.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Fixes: 34e1b1bb7324 ("ALSA: hda: cs35l56: Stop creating ALSA controls for firmware coefficients")
Link: https://patch.msgid.link/20240813110750.2814-1-rf@opensource.cirrus.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/cs35l56_hda.c

index 31cc92bac89a684ceb4dcc39544090249ba19e2d..a9dfd62637cf4cdbab2cca065751d459bdf34ab3 100644 (file)
@@ -413,7 +413,7 @@ static void cs35l56_hda_remove_controls(struct cs35l56_hda *cs35l56)
 }
 
 static const struct cs_dsp_client_ops cs35l56_hda_client_ops = {
-       .control_remove = hda_cs_dsp_control_remove,
+       /* cs_dsp requires the client to provide this even if it is empty */
 };
 
 static int cs35l56_hda_request_firmware_file(struct cs35l56_hda *cs35l56,