]> git.ipfire.org Git - thirdparty/kmod.git/commitdiff
ci: 'temporary' disable sanitizers for 32bit builds
authorEmil Velikov <emil.l.velikov@gmail.com>
Mon, 16 Jun 2025 23:30:40 +0000 (00:30 +0100)
committerLucas De Marchi <lucas.de.marchi@gmail.com>
Fri, 27 Jun 2025 20:22:56 +0000 (15:22 -0500)
Currently running 32bit tests alongside sanitizers, segfaults due to our
syscall wrapper. Just disable the sanitizers, which means we get at
least some 32bit test coverage.

On a couple of attempts, I wasn't able to get a proper/robust solution,
as outlined in init_module.c - we need vsyscall() which does not exist.

Considering some distributions are dropping 32bit/i686 support, it may
be that we'll nuke these builds from CI sooner than later.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Link: https://github.com/kmod-project/kmod/pull/383
Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>
.github/workflows/main.yml

index 8bff6a59114ce6c7f586b66b7f6638fe3d2f335b..0295433844546e06ac9e67e77eafcfcb85490fb1 100644 (file)
@@ -31,13 +31,10 @@ jobs:
             meson_setup: '-Db_sanitize=none'
             only_bits: '64'
           - container: 'archlinux:multilib-devel'
-            skip_test: '32'
           - container: 'debian:bullseye-slim'
             meson_setup: '-Dzstd=disabled -Dxz=disabled -Dzlib=disabled -Dopenssl=enabled -Dtools=true'
             only_compiler: 'gcc'
-            skip_test: '32'
           - container: 'debian:unstable'
-            skip_test: '32'
           - container: 'fedora:latest'
             only_bits: '64'
           - container: 'fedora:latest'
@@ -45,13 +42,11 @@ jobs:
             only_bits: '64'
             custom: 'no-xz-dlopen-all'
           - container: 'ubuntu:22.04'
-            skip_test: '32'
           - container: 'ubuntu:22.04'
             meson_setup: '-Ddlopen=zstd,zlib'
             only_bits: '64'
             custom: 'dlopen-zstd-zlib'
           - container: 'ubuntu:24.04'
-            skip_test: '32'
 
           # Special configurations
 
@@ -131,6 +126,9 @@ jobs:
             if [[ "$2" == "32" ]]; then
               echo "::notice::TODO fix and reuse the original options."
               setup_options="$setup_options -Dzstd=disabled -Dxz=disabled -Dzlib=disabled -Dopenssl=disabled"
+
+              echo "::notice::TODO fix and re-enable sanitizer(s)."
+              setup_options="$setup_options -Db_sanitize=none"
             fi
 
             [[ -n "${{ matrix.linker }}" ]] && export CC_LD="${{ matrix.linker }}"