]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
eth: fbnic: Use wake instead of start
authorMohsin Bashir <hmohsin@meta.com>
Wed, 8 Apr 2026 00:24:15 +0000 (17:24 -0700)
committerJakub Kicinski <kuba@kernel.org>
Fri, 10 Apr 2026 03:36:26 +0000 (20:36 -0700)
fbnic_up() calls netif_tx_start_all_queues(), which only clears
__QUEUE_STATE_DRV_XOFF.  If qdisc backlog has accumulated on any TX
queue before the reconfiguration (e.g. ring resize via ethtool -G),
start does not call __netif_schedule() to kick the qdisc, so the
pending backlog is never drained and the queue stalls.

Switch to netif_tx_wake_all_queues(), which clears DRV_XOFF and also
calls __netif_schedule() on every queue, ensuring any backlog that
built up before the down/up cycle is promptly dequeued.

Fixes: bc6107771bb4 ("eth: fbnic: Allocate a netdevice and napi vectors with queues")
Signed-off-by: Mohsin Bashir <hmohsin@meta.com>
Link: https://patch.msgid.link/20260408002415.2963915-1-mohsin.bashr@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/meta/fbnic/fbnic_pci.c

index 3fa9d1910daa1ec273b9a9a2bd27754b8640d6f5..8f331358c97256e5e668df18e4eacc96820863df 100644 (file)
@@ -139,7 +139,7 @@ void fbnic_up(struct fbnic_net *fbn)
 
        /* Enable Tx/Rx processing */
        fbnic_napi_enable(fbn);
-       netif_tx_start_all_queues(fbn->netdev);
+       netif_tx_wake_all_queues(fbn->netdev);
 
        fbnic_service_task_start(fbn);