ASoC: codecs: fix the right check and simplify code

In the file drivers/base/platform.c, the return description of
platform_get_irq is 'non-zero IRQ number on success, negative
error number on failure.', so the check is wrong, fix it. And
when get irq failed, the function platform_get_irq logs an error
message.

Fixes: 5e2404493f9f ("ASoC: codecs: add MT6357 support")
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Link: https://patch.msgid.link/20240908134604.3652-1-tangbin@cmss.chinamobile.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/mediatek/mt8365/mt8365-afe-pcm.c b/sound/soc/mediatek/mt8365/mt8365-afe-pcm.c
index df6dd8c5bbe5e2d098923f35a04941b43a6c9313..4ec86b71dd8898473a7fd2296e217907b217f0d0 100644 (file)
--- a/sound/soc/mediatek/mt8365/mt8365-afe-pcm.c
+++ b/sound/soc/mediatek/mt8365/mt8365-afe-pcm.c
@@ -2155,11 +2155,11 @@ static int mt8365_afe_pcm_dev_probe(struct platform_device *pdev)
        for (i = 0; i < afe->irqs_size; i++)
                afe->irqs[i].irq_data = &irq_data[i];
 
-       irq_id = platform_get_irq(pdev, 0);
-       if (!irq_id) {
-               dev_err_probe(afe->dev, irq_id, "np %s no irq\n", afe->dev->of_node->name);
-               return -ENXIO;
-       }
+       ret = platform_get_irq(pdev, 0);
+       if (ret < 0)
+               return ret;
+
+       irq_id = ret;
        ret = devm_request_irq(afe->dev, irq_id, mt8365_afe_irq_handler,
                               0, "Afe_ISR_Handle", (void *)afe);
        if (ret)