]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ARM: dts: ti/omap: omap4-serial: fix interrupts syntax
authorAndreas Kemnade <andreas@kemnade.info>
Mon, 30 Dec 2024 19:55:56 +0000 (20:55 +0100)
committerKevin Hilman <khilman@baylibre.com>
Thu, 6 Feb 2025 00:26:34 +0000 (16:26 -0800)
Usually interrupts are overwritten in the board file to specify a
mux-dependent dedicated wakeup irq, so there is interrupts and
interrupts-extended property which is not allowed. That has generated a
lot of noise during dts changes if just a phandle involved has randomly
changed.

Avoid that mess by specifying interrupts-extended in the dtsi file.

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
Reported-by: Rob Herring <robh@kernel.org>
Closes: https://lore.kernel.org/linux-omap/173558214240.2262575.18233884215338168789.robh@kernel.org/
Closes: https://lore.kernel.org/linux-omap/172784021601.525825.18405282128990798038.robh@kernel.org/
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Link: https://lore.kernel.org/r/20241230195556.112118-1-andreas@kemnade.info
Signed-off-by: Kevin Hilman <khilman@baylibre.com>
arch/arm/boot/dts/ti/omap/omap4-l4.dtsi

index 3fcef3080eaec8180f245eadc12b2560fc1b4976..150dd84c9e0f749585de5fd4edb3bc673a8209ea 100644 (file)
                        uart3: serial@0 {
                                compatible = "ti,omap4-uart";
                                reg = <0x0 0x100>;
-                               interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>;
+                               interrupts-extended = <&wakeupgen GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>;
                                clock-frequency = <48000000>;
                        };
                };
                        uart1: serial@0 {
                                compatible = "ti,omap4-uart";
                                reg = <0x0 0x100>;
-                               interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>;
+                               interrupts-extended = <&wakeupgen GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>;
                                clock-frequency = <48000000>;
                        };
                };
                        uart2: serial@0 {
                                compatible = "ti,omap4-uart";
                                reg = <0x0 0x100>;
-                               interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
+                               interrupts-extended = <&wakeupgen GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
                                clock-frequency = <48000000>;
                        };
                };
                        uart4: serial@0 {
                                compatible = "ti,omap4-uart";
                                reg = <0x0 0x100>;
-                               interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>;
+                               interrupts-extended = <&wakeupgen GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>;
                                clock-frequency = <48000000>;
                        };
                };