]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
s390/ap: function rework based on compiler warning
authorHarald Freudenberger <freude@linux.ibm.com>
Wed, 20 Oct 2021 14:14:11 +0000 (16:14 +0200)
committerVasily Gorbik <gor@linux.ibm.com>
Tue, 26 Oct 2021 13:21:30 +0000 (15:21 +0200)
Slight rework of function __ap_revise_reserved()
because of unused variable warning when build with W=1.
This patch introduces an additional debug feature warning
message when device_reprobe() returns with failure.
However, the return value of __ap_revise_reserved()
is still hard coded to 0 as this is a callback function
to be used together with bus_for_each_dev() and thus
the return value indicates to go on with the
bus_for_each_dev() loop and not apport on a failure
of something within this function.

Signed-off-by: Harald Freudenberger <freude@linux.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
drivers/s390/crypto/ap_bus.c

index 806d184482a904c65d271b5ec3565862d3a0896e..1986243f9cd392d1941e5635170960c45b060135 100644 (file)
@@ -793,6 +793,9 @@ static int __ap_revise_reserved(struct device *dev, void *dummy)
                        AP_DBF_DBG("%s reprobing queue=%02x.%04x\n",
                                   __func__, card, queue);
                        rc = device_reprobe(dev);
+                       if (rc)
+                               AP_DBF_WARN("%s reprobing queue=%02x.%04x failed\n",
+                                           __func__, card, queue);
                }
        }