]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
x86/resctrl: Use kthread_run_on_cpu()
authorFrederic Weisbecker <frederic@kernel.org>
Wed, 7 Aug 2024 16:02:08 +0000 (18:02 +0200)
committerBorislav Petkov (AMD) <bp@alien8.de>
Mon, 9 Dec 2024 19:19:48 +0000 (20:19 +0100)
Use the proper API instead of open coding it.

Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Acked-by: Reinette Chatre <reinette.chatre@intel.com>
Link: https://lore.kernel.org/r/20240807160228.26206-3-frederic@kernel.org
arch/x86/kernel/cpu/resctrl/pseudo_lock.c

index 972e6b6b0481ff23ab045ce3fdb774d54b8fe252..6c60c16a9dd037d598c0731d4b20877c4ec7a9f9 100644 (file)
@@ -1205,20 +1205,14 @@ static int pseudo_lock_measure_cycles(struct rdtgroup *rdtgrp, int sel)
        plr->cpu = cpu;
 
        if (sel == 1)
-               thread = kthread_create_on_node(measure_cycles_lat_fn, plr,
-                                               cpu_to_node(cpu),
-                                               "pseudo_lock_measure/%u",
-                                               cpu);
+               thread = kthread_run_on_cpu(measure_cycles_lat_fn, plr,
+                                           cpu, "pseudo_lock_measure/%u");
        else if (sel == 2)
-               thread = kthread_create_on_node(measure_l2_residency, plr,
-                                               cpu_to_node(cpu),
-                                               "pseudo_lock_measure/%u",
-                                               cpu);
+               thread = kthread_run_on_cpu(measure_l2_residency, plr,
+                                           cpu, "pseudo_lock_measure/%u");
        else if (sel == 3)
-               thread = kthread_create_on_node(measure_l3_residency, plr,
-                                               cpu_to_node(cpu),
-                                               "pseudo_lock_measure/%u",
-                                               cpu);
+               thread = kthread_run_on_cpu(measure_l3_residency, plr,
+                                           cpu, "pseudo_lock_measure/%u");
        else
                goto out;
 
@@ -1226,8 +1220,6 @@ static int pseudo_lock_measure_cycles(struct rdtgroup *rdtgrp, int sel)
                ret = PTR_ERR(thread);
                goto out;
        }
-       kthread_bind(thread, cpu);
-       wake_up_process(thread);
 
        ret = wait_event_interruptible(plr->lock_thread_wq,
                                       plr->thread_done == 1);
@@ -1315,18 +1307,14 @@ int rdtgroup_pseudo_lock_create(struct rdtgroup *rdtgrp)
 
        plr->thread_done = 0;
 
-       thread = kthread_create_on_node(pseudo_lock_fn, rdtgrp,
-                                       cpu_to_node(plr->cpu),
-                                       "pseudo_lock/%u", plr->cpu);
+       thread = kthread_run_on_cpu(pseudo_lock_fn, rdtgrp,
+                                   plr->cpu, "pseudo_lock/%u");
        if (IS_ERR(thread)) {
                ret = PTR_ERR(thread);
                rdt_last_cmd_printf("Locking thread returned error %d\n", ret);
                goto out_cstates;
        }
 
-       kthread_bind(thread, plr->cpu);
-       wake_up_process(thread);
-
        ret = wait_event_interruptible(plr->lock_thread_wq,
                                       plr->thread_done == 1);
        if (ret < 0) {