]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
Fix clang 20 sometimes-uninitialized warnings
authorGary Lockyer <gary@catalyst.net.nz>
Wed, 21 May 2025 22:34:23 +0000 (10:34 +1200)
committerDouglas Bagnall <dbagnall@samba.org>
Wed, 28 May 2025 23:04:38 +0000 (23:04 +0000)
Fix clang 20:
  variable '' is uninitialized where 'if' condition is true

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Anoop C S <anoopcs@samba.org>
buildtools/wafsamba/samba_autoconf.py
source4/torture/smb2/timestamps.c

index 586b789a9234651293047621beabb3b3aa379e80..8b1f8b9da01e7b3a4f33258331b6cdbcf3aa2c40 100644 (file)
@@ -843,7 +843,6 @@ int main(void) {
             conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Wno-error=unused-but-set-variable', testflags=True)
             conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Wno-error=unused-function', testflags=True)
             conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Wno-error=format-truncation', testflags=True)
-            conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Wno-error=sometimes-uninitialized', testflags=True)
             conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Wno-error=cast-qual', testflags=True)
             conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Wno-error=format-nonliteral', testflags=True)
 
index 47d645eacf2635f2a7555462cc344c4fdc142604..54dea8dbc95e1ce89188a68771a451021fa0dc4f 100644 (file)
@@ -1164,7 +1164,7 @@ static bool getinfo_both(struct torture_context *tctx,
        union smb_fileinfo finfo;
        union smb_fileinfo pinfo;
        struct smb2_create cr;
-       struct smb2_handle h2;
+       struct smb2_handle h2 = {0};
        NTSTATUS status;
        bool ret = true;