]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
4.19-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 17 Sep 2019 18:28:38 +0000 (20:28 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 17 Sep 2019 18:28:38 +0000 (20:28 +0200)
added patches:
nvmem-use-the-same-permissions-for-eeprom-as-for-nvmem.patch

queue-4.19/nvmem-use-the-same-permissions-for-eeprom-as-for-nvmem.patch [new file with mode: 0644]
queue-4.19/series

diff --git a/queue-4.19/nvmem-use-the-same-permissions-for-eeprom-as-for-nvmem.patch b/queue-4.19/nvmem-use-the-same-permissions-for-eeprom-as-for-nvmem.patch
new file mode 100644 (file)
index 0000000..017e23c
--- /dev/null
@@ -0,0 +1,51 @@
+From e70d8b287301eb6d7c7761c6171c56af62110ea3 Mon Sep 17 00:00:00 2001
+From: Jean Delvare <jdelvare@suse.de>
+Date: Sun, 28 Jul 2019 18:42:55 +0200
+Subject: nvmem: Use the same permissions for eeprom as for nvmem
+
+From: Jean Delvare <jdelvare@suse.de>
+
+commit e70d8b287301eb6d7c7761c6171c56af62110ea3 upstream.
+
+The compatibility "eeprom" attribute is currently root-only no
+matter what the configuration says. The "nvmem" attribute does
+respect the setting of the root_only configuration bit, so do the
+same for "eeprom".
+
+Signed-off-by: Jean Delvare <jdelvare@suse.de>
+Fixes: b6c217ab9be6 ("nvmem: Add backwards compatibility support for older EEPROM drivers.")
+Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
+Cc: Andrew Lunn <andrew@lunn.ch>
+Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
+Cc: Arnd Bergmann <arnd@arndb.de>
+Link: https://lore.kernel.org/r/20190728184255.563332e6@endymion
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ drivers/nvmem/core.c |   15 +++++++++++----
+ 1 file changed, 11 insertions(+), 4 deletions(-)
+
+--- a/drivers/nvmem/core.c
++++ b/drivers/nvmem/core.c
+@@ -415,10 +415,17 @@ static int nvmem_setup_compat(struct nvm
+       if (!config->base_dev)
+               return -EINVAL;
+-      if (nvmem->read_only)
+-              nvmem->eeprom = bin_attr_ro_root_nvmem;
+-      else
+-              nvmem->eeprom = bin_attr_rw_root_nvmem;
++      if (nvmem->read_only) {
++              if (config->root_only)
++                      nvmem->eeprom = bin_attr_ro_root_nvmem;
++              else
++                      nvmem->eeprom = bin_attr_ro_nvmem;
++      } else {
++              if (config->root_only)
++                      nvmem->eeprom = bin_attr_rw_root_nvmem;
++              else
++                      nvmem->eeprom = bin_attr_rw_nvmem;
++      }
+       nvmem->eeprom.attr.name = "eeprom";
+       nvmem->eeprom.size = nvmem->size;
+ #ifdef CONFIG_DEBUG_LOCK_ALLOC
index e46fb968638797b1ae182a52ae3727056b57f724..229909126d76a723e9553c6b5e56f55d27d9b9f2 100644 (file)
@@ -46,3 +46,4 @@ modules-fix-bug-when-load-module-with-rodata-n.patch
 modules-fix-compile-error-if-don-t-have-strict-module-rwx.patch
 platform-x86-pmc_atom-add-cb4063-beckhoff-automation-board-to-critclk_systems-dmi-table.patch
 rsi-fix-a-double-free-bug-in-rsi_91x_deinit.patch
+nvmem-use-the-same-permissions-for-eeprom-as-for-nvmem.patch