]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
usb: chipidea: Use of_property_present()
authorRob Herring (Arm) <robh@kernel.org>
Wed, 31 Jul 2024 19:12:56 +0000 (13:12 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 7 Aug 2024 10:49:51 +0000 (12:49 +0200)
Use of_property_present() to test for property presence rather than
of_get_property(). This is part of a larger effort to remove callers
of of_get_property() and similar functions. of_get_property() leaks
the DT property data pointer which is a problem for dynamically
allocated nodes which may be freed.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Link: https://lore.kernel.org/r/20240731191312.1710417-18-robh@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/chipidea/ci_hdrc_imx.c

index bdc04ce919f7a509ea3b8da72ad2e199125bd018..c64ab0e07ea030cc7f23120fea1d211408955918 100644 (file)
@@ -128,7 +128,7 @@ static struct imx_usbmisc_data *usbmisc_get_init_data(struct device *dev)
         * In case the fsl,usbmisc property is not present this device doesn't
         * need usbmisc. Return NULL (which is no error here)
         */
-       if (!of_get_property(np, "fsl,usbmisc", NULL))
+       if (!of_property_present(np, "fsl,usbmisc"))
                return NULL;
 
        data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);