]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
selftest: net: prevent use of uninitialized variable
authorAlessandro Zanni <alessandro.zanni87@gmail.com>
Thu, 23 Oct 2025 20:53:52 +0000 (22:53 +0200)
committerJakub Kicinski <kuba@kernel.org>
Sat, 25 Oct 2025 01:43:37 +0000 (18:43 -0700)
Fix to avoid the usage of the `ret` variable uninitialized in the
following macro expansions.

It solves the following warning:

In file included from netlink-dumps.c:21:
netlink-dumps.c: In function ‘dump_extack’:
../kselftest_harness.h:788:35: warning: ‘ret’ may be used uninitialized [-Wmaybe-uninitialized]
  788 |                         intmax_t  __exp_print = (intmax_t)__exp; \
      |                                   ^~~~~~~~~~~
../kselftest_harness.h:631:9: note: in expansion of macro ‘__EXPECT’
  631 |         __EXPECT(expected, #expected, seen, #seen, ==, 0)
      |         ^~~~~~~~
netlink-dumps.c:169:9: note: in expansion of macro ‘EXPECT_EQ’
  169 |         EXPECT_EQ(ret, FOUND_EXTACK);
      |         ^~~~~~~~~

The issue can be reproduced, building the tests, with the command:
make -C tools/testing/selftests TARGETS=net

Signed-off-by: Alessandro Zanni <alessandro.zanni87@gmail.com>
Link: https://patch.msgid.link/20251023205354.28249-1-alessandro.zanni87@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/netlink-dumps.c

index 7618ebe528a4c4e2612c91502848d881cfbcf121..679b6c77ace7c28ce6e9f47ad1e29040a8293875 100644 (file)
@@ -143,6 +143,7 @@ TEST(dump_extack)
        EXPECT_EQ(n, -1);
        EXPECT_EQ(errno, ENOBUFS);
 
+       ret = NO_CTRL;
        for (i = 0; i < cnt; i++) {
                struct ext_ack ea = {};