]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
libbpf: Avoid possible use of uninitialized mod_len
authorAchill Gilgenast <fossdd@pwned.life>
Tue, 29 Jul 2025 09:45:53 +0000 (11:45 +0200)
committerAlexei Starovoitov <ast@kernel.org>
Thu, 31 Jul 2025 18:39:46 +0000 (11:39 -0700)
Though mod_len is only read when mod_name != NULL and both are initialized
together, gcc15 produces a warning with -Werror=maybe-uninitialized:

libbpf.c: In function 'find_kernel_btf_id.constprop':
libbpf.c:10100:33: error: 'mod_len' may be used uninitialized [-Werror=maybe-uninitialized]
10100 |                 if (mod_name && strncmp(mod->name, mod_name, mod_len) != 0)
      |                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
libbpf.c:10070:21: note: 'mod_len' was declared here
10070 |         int ret, i, mod_len;
      |                     ^~~~~~~

Silence the false positive.

Signed-off-by: Achill Gilgenast <fossdd@pwned.life>
Acked-by: Yonghong Song <yonghong.song@linux.dev>
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
Link: https://lore.kernel.org/r/20250729094611.2065713-1-fossdd@pwned.life
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
tools/lib/bpf/libbpf.c

index e067cb5776bda1b86162855a32cbc2d8f317b6d8..fb4d92c5c339413c0661d5efcf49ef93ea258fbd 100644 (file)
@@ -10096,7 +10096,7 @@ static int find_kernel_btf_id(struct bpf_object *obj, const char *attach_name,
                              enum bpf_attach_type attach_type,
                              int *btf_obj_fd, int *btf_type_id)
 {
-       int ret, i, mod_len;
+       int ret, i, mod_len = 0;
        const char *fn_name, *mod_name = NULL;
 
        fn_name = strchr(attach_name, ':');