]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ipv4: Unmask upper DSCP bits in ip_send_unicast_reply()
authorIdo Schimmel <idosch@nvidia.com>
Thu, 29 Aug 2024 06:54:55 +0000 (09:54 +0300)
committerDavid S. Miller <davem@davemloft.net>
Sat, 31 Aug 2024 16:44:51 +0000 (17:44 +0100)
The function calls flowi4_init_output() to initialize an IPv4 flow key
with which it then performs a FIB lookup using ip_route_output_flow().

'arg->tos' with which the TOS value in the IPv4 flow key (flowi4_tos) is
initialized contains the full DS field. Unmask the upper DSCP bits so
that in the future the FIB lookup could be performed according to the
full DSCP value.

Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Guillaume Nault <gnault@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/ip_output.c

index b90d0f78ac8080f6e5aba2382b11075253f85d61..eea443b7f65e209fe005d20a5ad895e9cd902b6d 100644 (file)
@@ -77,6 +77,7 @@
 #include <net/inetpeer.h>
 #include <net/inet_ecn.h>
 #include <net/lwtunnel.h>
+#include <net/inet_dscp.h>
 #include <linux/bpf-cgroup.h>
 #include <linux/igmp.h>
 #include <linux/netfilter_ipv4.h>
@@ -1621,7 +1622,7 @@ void ip_send_unicast_reply(struct sock *sk, struct sk_buff *skb,
 
        flowi4_init_output(&fl4, oif,
                           IP4_REPLY_MARK(net, skb->mark) ?: sk->sk_mark,
-                          RT_TOS(arg->tos),
+                          arg->tos & INET_DSCP_MASK,
                           RT_SCOPE_UNIVERSE, ip_hdr(skb)->protocol,
                           ip_reply_arg_flowi_flags(arg),
                           daddr, saddr,