re PR tree-optimization/33735 (verify_stmts failed: missing PHI def)

gcc/ChangeLog:
PR tree-optimization/33735
PR tree-optimization/33572
* tree-inline.c (update_ssa_across_abnormal_edges): Revert
2007-10-09's change.
* except.c (duplicate_eh_regions): Don't look for prev_try
beyond ERT_ALLOWED_EXCEPTIONS with an empty list.
gcc/testsuite/ChangeLog:
PR tree-optimization/33735
* g++.dg/torture/pr33735.C: New.

From-SVN: r129356

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index f627ef7d157d61deec851408f33be1a2344d2f50..2348ecc98438d0b87e8f2d9ec73e48963b2effc1 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,12 @@
+2007-10-15  Alexandre Oliva  <aoliva@redhat.com>
+
+       PR tree-optimization/33735
+       PR tree-optimization/33572
+       * tree-inline.c (update_ssa_across_abnormal_edges): Revert
+       2007-10-09's change.
+       * except.c (duplicate_eh_regions): Don't look for prev_try
+       beyond ERT_ALLOWED_EXCEPTIONS with an empty list.
+
 2007-10-15  Alexandre Oliva  <aoliva@redhat.com>
 
        PR middle-end/33706

diff --git a/gcc/except.c b/gcc/except.c
index fe98299450d19ca9ba1a1bc66a9504fbb71a220b..0fbda613961a02536354bc119e804dca2ee34b79 100644 (file)
--- a/gcc/except.c
+++ b/gcc/except.c
@@ -1005,7 +1005,9 @@ duplicate_eh_regions (struct function *ifun, duplicate_eh_regions_map map,
     for (prev_try = VEC_index (eh_region, cfun->eh->region_array, outer_region);
          prev_try && prev_try->type != ERT_TRY;
         prev_try = prev_try->outer)
-      if (prev_try->type == ERT_MUST_NOT_THROW)
+      if (prev_try->type == ERT_MUST_NOT_THROW
+         || (prev_try->type == ERT_ALLOWED_EXCEPTIONS
+             && !prev_try->u.allowed.type_list))
        {
          prev_try = NULL;
          break;

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 7f09cddb89ca9521584fced0d203d99f04acaebe..12b8cba6cb2fbf4a1ea5b0a065a6718ce6baea22 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2007-10-15  Alexandre Oliva  <aoliva@redhat.com>
+
+       PR tree-optimization/33735
+       * g++.dg/torture/pr33735.C: New.
+
 2007-10-15  Alexandre Oliva  <aoliva@redhat.com>
 
        PR middle-end/33706

diff --git a/gcc/testsuite/g++.dg/torture/pr33735.C b/gcc/testsuite/g++.dg/torture/pr33735.C
new file mode 100644 (file)
index 0000000..0a90745
--- /dev/null
+++ b/gcc/testsuite/g++.dg/torture/pr33735.C
@@ -0,0 +1,21 @@
+// { dg-do compile }
+#include <string>
+typedef struct _ts { } PyThreadState;
+PyThreadState * Py_NewInterpreter(void);
+void Py_EndInterpreter(PyThreadState *);
+class ApplicationError {
+public:
+    ApplicationError(std::string errormsg) : errormsg(errormsg)  { }
+    std::string errormsg;
+};
+void run()
+{
+    PyThreadState *py_state=__null;
+    try {
+        if (!(py_state=Py_NewInterpreter()))
+            throw ApplicationError("error");
+    }
+    catch(ApplicationError e) {
+        Py_EndInterpreter(py_state);
+    }
+}

diff --git a/gcc/tree-inline.c b/gcc/tree-inline.c
index 7ebfbcd4a6ce20a0b8e79d7e1a9c68cef64b348f..55aef3d5c6e30f408dfb2ecd7450ec7e3615bd84 100644 (file)
--- a/gcc/tree-inline.c
+++ b/gcc/tree-inline.c
@@ -1064,8 +1064,7 @@ update_ssa_across_abnormal_edges (basic_block bb, basic_block ret_bb,
              }
 
            re = find_edge (ret_bb, e->dest);
-           if (!re)
-             continue;
+           gcc_assert (re);
            gcc_assert ((re->flags & (EDGE_EH | EDGE_ABNORMAL))
                        == (e->flags & (EDGE_EH | EDGE_ABNORMAL)));