]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
watchdog: rti_wdt: Fix an OF node leak in rti_wdt_probe()
authorJoe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Sun, 5 Jan 2025 11:17:18 +0000 (20:17 +0900)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Mon, 6 Jan 2025 18:38:07 +0000 (19:38 +0100)
rti_wdt_probe() does not release the OF node reference obtained by
of_parse_phandle(). Add a of_node_put() call.

This was found by an experimental verification tool that I am
developing. Due to the lack of the actual device, no runtime test was
able to be performed.

Fixes: f20ca595ae23 ("watchdog:rit_wdt: Add support for WDIOF_CARDRESET")
Signed-off-by: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20250105111718.4184192-1-joe@pf.is.s.u-tokyo.ac.jp
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/rti_wdt.c

index e01dd1c13e2c4ef77bc768d4b92d59bc12187fca..d1f9ce4100a825ee5924f4a4f9f20d7f97b6905e 100644 (file)
@@ -302,6 +302,7 @@ static int rti_wdt_probe(struct platform_device *pdev)
        node = of_parse_phandle(pdev->dev.of_node, "memory-region", 0);
        if (node) {
                ret = of_address_to_resource(node, 0, &res);
+               of_node_put(node);
                if (ret) {
                        dev_err(dev, "No memory address assigned to the region.\n");
                        goto err_iomap;