]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commitdiff
Fix known minor objdump leak
authorAlan Modra <amodra@gmail.com>
Tue, 14 Jan 2025 10:36:32 +0000 (21:06 +1030)
committerAlan Modra <amodra@gmail.com>
Wed, 15 Jan 2025 11:49:31 +0000 (22:19 +1030)
* objdump.c (main): Free disassembler_options.

binutils/objdump.c

index 80044dea580227fba274b51bfc011fc18f660ae8..ebe586e0e3ae22962135bc60a64b738e664af928 100644 (file)
@@ -6001,12 +6001,14 @@ main (int argc, char **argv)
          {
            char *options;
            if (disassembler_options)
-             /* Ignore potential memory leak for now.  */
              options = concat (disassembler_options, ",",
                                optarg, (const char *) NULL);
            else
-             options = optarg;
+             options = xstrdup (optarg);
+           free (disassembler_options);
            disassembler_options = remove_whitespace_and_extra_commas (options);
+           if (!disassembler_options)
+             free (options);
          }
          break;
        case 'j':