validate_failures.py: Fix performance regression

2013-02-06  Bernhard Reutner-Fischer  <aldot@gcc.gnu.org>

	* testsuite-management/validate_failures.py
	(IsInterestingResult): Fix performance regression

From-SVN: r195811

diff --git a/contrib/ChangeLog b/contrib/ChangeLog
index eaccdbdeee9c6563461cc64a62a46283192cbf4e..0ace63edcf0bbc24f3988feca58a72819637cee1 100644 (file)
--- a/contrib/ChangeLog
+++ b/contrib/ChangeLog
@@ -1,3 +1,8 @@
+2013-02-06  Bernhard Reutner-Fischer  <aldot@gcc.gnu.org>
+
+       * testsuite-management/validate_failures.py
+       (IsInterestingResult): Fix performance regression
+
 2013-02-04  Richard Sandiford  <rdsandiford@googlemail.com>
 
        * update-copyright.py: New file.

diff --git a/contrib/testsuite-management/validate_failures.py b/contrib/testsuite-management/validate_failures.py
index ec51de91b6b1107d88acc8a1b7451df2413fb1ef..5c80ca30be85a6398b8ae6fab80be2b726180848 100755 (executable)
--- a/contrib/testsuite-management/validate_failures.py
+++ b/contrib/testsuite-management/validate_failures.py
@@ -62,6 +62,7 @@ import sys
 
 # Handled test results.
 _VALID_TEST_RESULTS = [ 'FAIL', 'UNRESOLVED', 'XPASS', 'ERROR' ]
+_VALID_TEST_RESULTS_REX = re.compile("%s" % "|".join(_VALID_TEST_RESULTS))
 
 # Subdirectory of srcdir in which to find the manifest file.
 _MANIFEST_SUBDIR = 'contrib/testsuite-management'
@@ -210,7 +211,7 @@ def IsInterestingResult(line):
   if '|' in line:
     (_, line) = line.split('|', 1)
     line = line.strip()
-  return any(line.startswith(result) for result in _VALID_TEST_RESULTS)
+  return bool(_VALID_TEST_RESULTS_REX.match(line))
 
 
 def IsInclude(line):