]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
CLEANUP: quic: complete ABORT_NOW with a TODO comment
authorAmaury Denoyelle <adenoyelle@haproxy.com>
Fri, 4 Mar 2022 15:51:20 +0000 (16:51 +0100)
committerAmaury Denoyelle <adenoyelle@haproxy.com>
Fri, 4 Mar 2022 15:56:51 +0000 (16:56 +0100)
Add a TODO comment to not forget to properly implement error returned by
qcs_push_frame.

src/mux_quic.c

index c6f12cb85f7a4cce20f5e5abfed91aeeff7e22b5..3ae919364c8caa8c42260a7df76f70fa04206bd1 100644 (file)
@@ -418,8 +418,7 @@ static int qc_send(struct qcc *qcc)
                if (b_data(buf)) {
                        char fin = qcs->flags & QC_SF_FIN_STREAM;
                        ret = qcs_push_frame(qcs, buf, fin, qcs->tx.offset);
-                       if (ret < 0)
-                               ABORT_NOW();
+                       BUG_ON(ret < 0); /* TODO handle this properly */
 
                        if (ret > 0) {
                                qcs_notify_send(qcs);