]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
MINOR: mux-h1: Don't release the conn_stream anymore when h1s is destroyed
authorChristopher Faulet <cfaulet@haproxy.com>
Mon, 8 Apr 2019 08:43:46 +0000 (10:43 +0200)
committerChristopher Faulet <cfaulet@haproxy.com>
Fri, 12 Apr 2019 20:06:53 +0000 (22:06 +0200)
An H1 stream is destroyed when the conn_stream is detached or when the H1
connection is destroyed. In the first case, the CS is released by the caller. In
the second one, because the connection is closed, no CS is attached anymore. In
both, there is no reason to release the conn_stream in h1s_destroy().

src/mux_h1.c

index 08dd0ba8f1257ebcae06250b371f9a05484ced37..30bb5f7aeee6f5b4f9e86b30febbc345c8984d80 100644 (file)
@@ -341,8 +341,6 @@ static void h1s_destroy(struct h1s *h1s)
                h1c->flags |= H1C_F_WAIT_NEXT_REQ;
                if (h1s->flags & (H1S_F_REQ_ERROR|H1S_F_RES_ERROR))
                        h1c->flags |= H1C_F_CS_ERROR;
-
-               cs_free(h1s->cs);
                pool_free(pool_head_h1s, h1s);
        }
 }