- Fix incomplete prototypes reported by Dag-Erling Smørgrav.

git-svn-id: file:///svn/unbound/trunk@3848 be551aaa-1e26-0410-a405-d3ace91eadb9

diff --git a/daemon/unbound.c b/daemon/unbound.c
index 7ec6edba1c6441e2c8c43b90eeb5aee96ccfaefc..73e9fcbb623439038ec243a2b98a89ffdf6920cb 100644 (file)
--- a/daemon/unbound.c
+++ b/daemon/unbound.c
@@ -93,7 +93,7 @@ void* unbound_start_brk = 0;
 #endif
 
 /** print usage. */
-static void usage()
+static void usage(void)
 {
        const char** m;
        const char *evnm="event", *evsys="", *evmethod="";

diff --git a/dns64/dns64.c b/dns64/dns64.c
index 2fde67841bb39958b899333affe960a697856627..5fa2096b8c5e585a6a51017e40ef917954ee16fc 100644 (file)
--- a/dns64/dns64.c
+++ b/dns64/dns64.c
@@ -872,7 +872,7 @@ static struct module_func_block dns64_block = {
  * Function for returning the above function block.
  */
 struct module_func_block *
-dns64_get_funcblock()
+dns64_get_funcblock(void)
 {
        return &dns64_block;
 }

diff --git a/doc/Changelog b/doc/Changelog
index 1b329969f5cf9dbbd3c3326fd0e26c9981cb656e..aff2078439ab5d47f5a97b5cc8f344bc8919a40a 100644 (file)
--- a/doc/Changelog
+++ b/doc/Changelog
@@ -1,6 +1,7 @@
 5 September 2016: Wouter
        - Fix #829: doc of sldns_wire2str_rdata_buf() return value has an
          off-by-one typo, from Jinmei Tatuya (Infoblox).
+       - Fix incomplete prototypes reported by Dag-Erling Smørgrav.
 
 2 September 2016: Wouter
        - Fix compile with openssl 1.1.0 with api=1.1.0.

diff --git a/smallapp/unbound-anchor.c b/smallapp/unbound-anchor.c
index 9269fad0b32534728c84b48aeac02ecd365e8214..08b8641a4a2011e58f745ddca6f2c5093cd0e23f 100644 (file)
--- a/smallapp/unbound-anchor.c
+++ b/smallapp/unbound-anchor.c
@@ -172,7 +172,7 @@ struct ip_list {
 
 /** Give unbound-anchor usage, and exit (1). */
 static void
-usage()
+usage(void)
 {
        printf("Usage:  unbound-anchor [opts]\n");
        printf("        Setup or update root anchor. "

diff --git a/smallapp/unbound-checkconf.c b/smallapp/unbound-checkconf.c
index b4536a173f0b83dcdf57df0867ea95565573d062..51f8e648ab7a4de9083469858ec8a27114c0291c 100644 (file)
--- a/smallapp/unbound-checkconf.c
+++ b/smallapp/unbound-checkconf.c
@@ -72,7 +72,7 @@
 
 /** Give checkconf usage, and exit (1). */
 static void
-usage()
+usage(void)
 {
        printf("Usage:  unbound-checkconf [file]\n");
        printf("        Checks unbound configuration file for errors.\n");

diff --git a/smallapp/unbound-control.c b/smallapp/unbound-control.c
index f3e32d9450ac5393859aa801c1edcc6f47d312ff..e054da3cf33ea3e5ea9d021d0f43a62845238533 100644 (file)
--- a/smallapp/unbound-control.c
+++ b/smallapp/unbound-control.c
@@ -65,7 +65,7 @@
 
 /** Give unbound-control usage, and exit (1). */
 static void
-usage()
+usage(void)
 {
        printf("Usage:  unbound-control [options] command\n");
        printf("        Remote control utility for unbound server.\n");

diff --git a/smallapp/unbound-host.c b/smallapp/unbound-host.c
index 25e1c95774ee169e99e90226ba0835ab2b494dcd..d7a36a23193e6f79006be23daf5df82d4c043195 100644 (file)
--- a/smallapp/unbound-host.c
+++ b/smallapp/unbound-host.c
@@ -72,7 +72,7 @@ static int verb = 0;
 
 /** Give unbound-host usage, and exit (1). */
 static void
-usage()
+usage(void)
 {
        printf("Usage:  unbound-host [-vdhr46] [-c class] [-t type] hostname\n");
        printf("                     [-y key] [-f keyfile] [-F namedkeyfile]\n");

diff --git a/testcode/lock_verify.c b/testcode/lock_verify.c
index 786d523c3118be73f2fcc514b4009ae938eda7f0..de2882b24c11978f11beba6480a161a27e6526fd 100644 (file)
--- a/testcode/lock_verify.c
+++ b/testcode/lock_verify.c
@@ -105,7 +105,7 @@ static int verb = 0;
 
 /** print program usage help */
 static void
-usage()
+usage(void)
 {
        printf("lock_verify <trace files>\n");
 }

diff --git a/testcode/memstats.c b/testcode/memstats.c
index fc56c0d3c1af2bde259cda40ce1e274f01da9561..1cca02e74dcfc865ce9ccf4852f1c75cd179da58 100644 (file)
--- a/testcode/memstats.c
+++ b/testcode/memstats.c
@@ -66,7 +66,7 @@ struct codeline {
 
 /** print usage and exit */
 static void
-usage()
+usage(void)
 {
        printf("usage:  memstats <logfile>\n");
        printf("statistics are printed on stdout.\n");

diff --git a/testcode/petal.c b/testcode/petal.c
index c22ac7e3ecfb16cf68877a942c3caa9b048213d3..def0f5e25d3f228b29b97709698f64a7088fd2b8 100644 (file)
--- a/testcode/petal.c
+++ b/testcode/petal.c
@@ -70,7 +70,7 @@ static int verb = 0;
 
 /** Give petal usage, and exit (1). */
 static void
-usage()
+usage(void)
 {
        printf("Usage:  petal [opts]\n");
        printf("        https daemon serves files from ./'host'/filename\n");

diff --git a/testcode/signit.c b/testcode/signit.c
index af4e0fe37cb3b98f3f5d5ae6d5b39891d59916c4..0eca0e088ee46a2b359145406eb1d4193ef54a6d 100644 (file)
--- a/testcode/signit.c
+++ b/testcode/signit.c
@@ -63,7 +63,7 @@ struct keysets {
 
 /** print usage and exit */
 static void
-usage()
+usage(void)
 {
        printf("usage:  signit expi ince keytag owner keyfile\n");
        printf("present rrset data on stdin.\n");

diff --git a/testcode/testbound.c b/testcode/testbound.c
index 674b39ac8942caf97a8ac52c7699c4f0fdd7c0e1..00502eea884979b0f0ba3a3213a1017aa3ca7858 100644 (file)
--- a/testcode/testbound.c
+++ b/testcode/testbound.c
@@ -67,7 +67,7 @@ static struct config_strlist* cfgfiles = NULL;
 
 /** give commandline usage for testbound. */
 static void
-testbound_usage()
+testbound_usage(void)
 {
        printf("usage: testbound [options]\n");
        printf("\ttest the unbound daemon.\n");

diff --git a/testcode/testpkts.c b/testcode/testpkts.c
index d1960a4108b571f4c9f6c671a5ffa1ab654ee4bc..c9ad9d069b568623218c5bd34988d60fc6a99ccc 100644 (file)
--- a/testcode/testpkts.c
+++ b/testcode/testpkts.c
@@ -239,7 +239,7 @@ static void adjustline(char* line, struct entry* e,
 }
 
 /** create new entry */
-static struct entry* new_entry()
+static struct entry* new_entry(void)
 {
        struct entry* e = (struct entry*)malloc(sizeof(struct entry));
        if(!e) error("out of memory");

diff --git a/util/storage/lookup3.c b/util/storage/lookup3.c
index ddcb56e7470f3c9b9ac3b8a2ae576aaff3b327c4..e9b05af37e3166794dc112f1fa5ca0ed66dd127a 100644 (file)
--- a/util/storage/lookup3.c
+++ b/util/storage/lookup3.c
@@ -820,7 +820,7 @@ uint32_t hashbig( const void *key, size_t length, uint32_t initval)
 #ifdef SELF_TEST
 
 /* used for timings */
-void driver1()
+void driver1(void)
 {
   uint8_t buf[256];
   uint32_t i;
@@ -842,7 +842,7 @@ void driver1()
 #define HASHLEN   1
 #define MAXPAIR 60
 #define MAXLEN  70
-void driver2()
+void driver2(void)
 {
   uint8_t qa[MAXLEN+1], qb[MAXLEN+2], *a = &qa[0], *b = &qb[1];
   uint32_t c[HASHSTATE], d[HASHSTATE], i=0, j=0, k, l, m=0, z;
@@ -912,7 +912,7 @@ void driver2()
 }
 
 /* Check for reading beyond the end of the buffer and alignment problems */
-void driver3()
+void driver3(void)
 {
   uint8_t buf[MAXLEN+20], *b;
   uint32_t len;
@@ -1003,7 +1003,7 @@ void driver3()
 }
 
 /* check for problems with nulls */
- void driver4()
+ void driver4(void)
 {
   uint8_t buf[1];
   uint32_t h,i,state[HASHSTATE];
@@ -1020,7 +1020,7 @@ void driver3()
 }
 
 
-int main()
+int main(void)
 {
   driver1();   /* test that the key is hashed: used for timings */
   driver2();   /* test that whole key is hashed thoroughly */

diff --git a/util/ub_event.c b/util/ub_event.c
index ebf9029e731235e1494e9775ab9af820bdccac5b..3b92be1a30251a6257898019b2674254d9e8bf19 100644 (file)
--- a/util/ub_event.c
+++ b/util/ub_event.c
@@ -137,7 +137,7 @@ static void (*NATIVE_BITS_CB(void (*cb)(int, short, void*)))(int, short, void*)
 #define AS_EVENT(x) ((struct event*)x)
 #define AS_UB_EVENT(x) ((struct ub_event*)x)
 
-const char* ub_event_get_version()
+const char* ub_event_get_version(void)
 {
        return event_get_version();
 }

diff --git a/util/ub_event.h b/util/ub_event.h
index cb42e7a7d23b927dbb5ef646caa95af805730e58..9739e6d833eea93ce885b11ea5f5447812d6abdf 100644 (file)
--- a/util/ub_event.h
+++ b/util/ub_event.h
@@ -63,7 +63,7 @@ struct event_base;
  * daemon compile, and will be "pluggable-event<PACKAGE_VERSION>" for 
  * libunbound.
  */
-const char* ub_event_get_version();
+const char* ub_event_get_version(void);
 /** Return the name, system and method for the pluggable event base */
 void ub_get_event_sys(struct ub_event_base*, const char** n, const char** s,
        const char** m);

diff --git a/util/ub_event_pluggable.c b/util/ub_event_pluggable.c
index c30880a5492a5ad48656cc0429841592f18f403a..4a9451263b7ce047418ff28c27fd78c32f5689bd 100644 (file)
--- a/util/ub_event_pluggable.c
+++ b/util/ub_event_pluggable.c
@@ -147,7 +147,7 @@ struct my_event {
 #define AS_MY_EVENT_BASE(x) ((struct my_event_base*)x)
 #define AS_MY_EVENT(x) ((struct my_event*)x)
 
-const char* ub_event_get_version()
+const char* ub_event_get_version(void)
 {
        return "pluggable-event"PACKAGE_VERSION;
 }

diff --git a/winrc/win_svc.c b/winrc/win_svc.c
index 74ace69fb19ecc307029845f8e8a3bdfaa6c83bf..ac97ef68beae34d70620bc1eacfe23dd051673eb 100644 (file)
--- a/winrc/win_svc.c
+++ b/winrc/win_svc.c
@@ -565,7 +565,7 @@ win_do_cron(void* ATTR_UNUSED(arg))
 
 /** Set the timer for cron for the next wake up */
 static void
-set_cron_timer()
+set_cron_timer(void)
 {
        struct timeval tv;
        int crontime;