]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
r8169: simplify setting hwmon attribute visibility
authorHeiner Kallweit <hkallweit1@gmail.com>
Tue, 3 Dec 2024 21:33:22 +0000 (22:33 +0100)
committerJakub Kicinski <kuba@kernel.org>
Thu, 5 Dec 2024 03:44:22 +0000 (19:44 -0800)
Use new member visible to simplify setting the static visibility.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Link: https://patch.msgid.link/dba77e76-be45-4a30-96c7-45e284072ad2@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/realtek/r8169_main.c

index cc14cd540f74860571182500a2c8769fdc6b85f2..6934bdee2a910ae8970869f36eee8d48345689f9 100644 (file)
@@ -5332,13 +5332,6 @@ static bool rtl_aspm_is_safe(struct rtl8169_private *tp)
        return false;
 }
 
-static umode_t r8169_hwmon_is_visible(const void *drvdata,
-                                     enum hwmon_sensor_types type,
-                                     u32 attr, int channel)
-{
-       return 0444;
-}
-
 static int r8169_hwmon_read(struct device *dev, enum hwmon_sensor_types type,
                            u32 attr, int channel, long *val)
 {
@@ -5355,7 +5348,7 @@ static int r8169_hwmon_read(struct device *dev, enum hwmon_sensor_types type,
 }
 
 static const struct hwmon_ops r8169_hwmon_ops = {
-       .is_visible =  r8169_hwmon_is_visible,
+       .visible = 0444,
        .read = r8169_hwmon_read,
 };