s390: rescue initrd as early as possible

To avoid multi-stage initrd rescue operation and to simplify
assumptions during early memory allocations move initrd at some final
safe destination as early as possible. This would also allow us to
drop .bss usage restrictions for some files.

Reviewed-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>

diff --git a/arch/s390/boot/compressed/decompressor.h b/arch/s390/boot/compressed/decompressor.h
index 011cbb6e0e08ec5a80234f7e68dd61f39a0d41e5..90d382d501d75a6a5a30b7c3c1aedb88e4ebc33e 100644 (file)
--- a/arch/s390/boot/compressed/decompressor.h
+++ b/arch/s390/boot/compressed/decompressor.h
@@ -7,11 +7,13 @@ static inline void *decompress_kernel(void) {}
 #else
 void *decompress_kernel(void);
 #endif
+unsigned long mem_safe_offset(void);
 
 struct vmlinux_info {
        unsigned long default_lma;
        void (*entry)(void);
        unsigned long image_size;       /* does not include .bss */
+       unsigned long bss_size;         /* uncompressed image .bss size */
 };
 
 extern char _vmlinux_info[];

diff --git a/arch/s390/boot/compressed/misc.c b/arch/s390/boot/compressed/misc.c
index 5dcf34e31f8d9907eb08e6f08765781db377796a..b773f81f5bffe035dba71d7ef74402ee4f912485 100644 (file)
--- a/arch/s390/boot/compressed/misc.c
+++ b/arch/s390/boot/compressed/misc.c
@@ -83,25 +83,22 @@ static void error(char *x)
        asm volatile("lpsw %0" : : "Q" (psw));
 }
 
-void *decompress_kernel(void)
-{
-       void *output, *kernel_end;
-
-       output = (void *) ALIGN((unsigned long) _end + HEAP_SIZE, PAGE_SIZE);
-       kernel_end = output + vmlinux.image_size;
+#define decompress_offset ALIGN((unsigned long)_end + HEAP_SIZE, PAGE_SIZE)
 
-#ifdef CONFIG_BLK_DEV_INITRD
+unsigned long mem_safe_offset(void)
+{
        /*
-        * Move the initrd right behind the end of the decompressed
-        * kernel image. This also prevents initrd corruption caused by
-        * bss clearing since kernel_end will always be located behind the
-        * current bss section..
+        * due to 4MB HEAD_SIZE for bzip2
+        * 'decompress_offset + vmlinux.image_size' could be larger than
+        * kernel at final position + its .bss, so take the larger of two
         */
-       if (INITRD_START && INITRD_SIZE && kernel_end > (void *) INITRD_START) {
-               memmove(kernel_end, (void *) INITRD_START, INITRD_SIZE);
-               INITRD_START = (unsigned long) kernel_end;
-       }
-#endif
+       return max(decompress_offset + vmlinux.image_size,
+                  vmlinux.default_lma + vmlinux.image_size + vmlinux.bss_size);
+}
+
+void *decompress_kernel(void)
+{
+       void *output = (void *)decompress_offset;
 
        __decompress(_compressed_start, _compressed_end - _compressed_start,
                     NULL, NULL, output, 0, NULL, error);

diff --git a/arch/s390/boot/startup.c b/arch/s390/boot/startup.c
index 474dee84d8a8cbe2d920268c9ef4d592a1be0200..5aeac7564e679c384e388cf9fe9ecb7877e7b160 100644 (file)
--- a/arch/s390/boot/startup.c
+++ b/arch/s390/boot/startup.c
@@ -1,12 +1,36 @@
 // SPDX-License-Identifier: GPL-2.0
 #include <linux/string.h>
+#include <asm/setup.h>
 #include "compressed/decompressor.h"
 #include "boot.h"
 
+#ifdef CONFIG_KERNEL_UNCOMPRESSED
+unsigned long mem_safe_offset(void)
+{
+       return vmlinux.default_lma + vmlinux.image_size + vmlinux.bss_size;
+}
+#endif
+
+static void rescue_initrd(void)
+{
+       unsigned long min_initrd_addr;
+
+       if (!IS_ENABLED(CONFIG_BLK_DEV_INITRD))
+               return;
+       if (!INITRD_START || !INITRD_SIZE)
+               return;
+       min_initrd_addr = mem_safe_offset();
+       if (min_initrd_addr <= INITRD_START)
+               return;
+       memmove((void *)min_initrd_addr, (void *)INITRD_START, INITRD_SIZE);
+       INITRD_START = min_initrd_addr;
+}
+
 void startup_kernel(void)
 {
        void *img;
 
+       rescue_initrd();
        if (!IS_ENABLED(CONFIG_KERNEL_UNCOMPRESSED)) {
                img = decompress_kernel();
                memmove((void *)vmlinux.default_lma, img, vmlinux.image_size);

diff --git a/arch/s390/kernel/early_nobss.c b/arch/s390/kernel/early_nobss.c
index 2d84fc48df3a7d44caaa08fb70157f58442f621a..8e96590b3a68c5eff2c912e0c1fde8f514b06b6d 100644 (file)
--- a/arch/s390/kernel/early_nobss.c
+++ b/arch/s390/kernel/early_nobss.c
@@ -13,7 +13,6 @@
 #include <linux/string.h>
 #include <asm/sections.h>
 #include <asm/lowcore.h>
-#include <asm/setup.h>
 #include <asm/timex.h>
 #include "entry.h"
 
@@ -32,26 +31,6 @@ static void __init reset_tod_clock(void)
        S390_lowcore.last_update_clock = TOD_UNIX_EPOCH;
 }
 
-static void __init rescue_initrd(void)
-{
-       unsigned long min_initrd_addr = (unsigned long) _end + (4UL << 20);
-
-       /*
-        * Just like in case of IPL from VM reader we make sure there is a
-        * gap of 4MB between end of kernel and start of initrd.
-        * That way we can also be sure that saving an NSS will succeed,
-        * which however only requires different segments.
-        */
-       if (!IS_ENABLED(CONFIG_BLK_DEV_INITRD))
-               return;
-       if (!INITRD_START || !INITRD_SIZE)
-               return;
-       if (INITRD_START >= min_initrd_addr)
-               return;
-       memmove((void *) min_initrd_addr, (void *) INITRD_START, INITRD_SIZE);
-       INITRD_START = min_initrd_addr;
-}
-
 static void __init clear_bss_section(void)
 {
        memset(__bss_start, 0, __bss_stop - __bss_start);
@@ -60,6 +39,5 @@ static void __init clear_bss_section(void)
 void __init startup_init_nobss(void)
 {
        reset_tod_clock();
-       rescue_initrd();
        clear_bss_section();
 }

diff --git a/arch/s390/kernel/vmlinux.lds.S b/arch/s390/kernel/vmlinux.lds.S
index 4b59d1ce71242f76ef9de418374f843d128a6ef0..4c5358ff9e0598bb78b5bf63783fed1e0f23dd3b 100644 (file)
--- a/arch/s390/kernel/vmlinux.lds.S
+++ b/arch/s390/kernel/vmlinux.lds.S
@@ -154,6 +154,7 @@ SECTIONS
                QUAD(_stext)                    /* default_lma */
                QUAD(startup_continue)          /* entry */
                QUAD(__bss_start - _stext)      /* image_size */
+               QUAD(__bss_stop - __bss_start)  /* bss_size */
        }
 
        /* Debugging sections.  */