]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
clang-tidy: use delete
authorRosen Penev <rosenp@gmail.com>
Tue, 5 Dec 2023 00:45:29 +0000 (16:45 -0800)
committerRosen Penev <rosenp@gmail.com>
Tue, 9 Jan 2024 00:09:26 +0000 (16:09 -0800)
Found with modernize-use-equals-delete

Signed-off-by: Rosen Penev <rosenp@gmail.com>
modules/bindbackend/bindbackend2.hh
modules/ldapbackend/powerldap.hh
pdns/dynmessenger.hh

index 14aff4835c6dfdb29c4e374271b2b3fa7405644b..2e88b8f696da629f66cca55a9b5c4e5196ba9591 100644 (file)
@@ -258,6 +258,9 @@ private:
 
     handle();
 
+    handle(const handle&) = delete;
+    handle& operator=(const handle&) = delete; // don't go copying this
+
     shared_ptr<const recordstorage_t> d_records;
     recordstorage_t::index<UnorderedNameTag>::type::const_iterator d_iter, d_end_iter;
 
@@ -274,9 +277,6 @@ private:
   private:
     bool get_normal(DNSResourceRecord&);
     bool get_list(DNSResourceRecord&);
-
-    void operator=(const handle&); // don't go copying this
-    handle(const handle&);
   };
 
   unique_ptr<SSqlStatement> d_getAllDomainMetadataQuery_stmt;
index 6b9fa2056d19089012a7b237ac01b4d737fca386..e8b030d78fb5b9c12e3623cc8f8377941c2b189c 100644 (file)
@@ -62,12 +62,12 @@ public:
     int d_msgid;
     bool d_finished;
 
-    SearchResult(const SearchResult& other);
-    SearchResult& operator=(const SearchResult& other);
-
   public:
     typedef std::unique_ptr<SearchResult> Ptr;
 
+    SearchResult(const SearchResult& other) = delete;
+    SearchResult& operator=(const SearchResult& other) = delete;
+
     SearchResult(int msgid, LDAP* ld);
     ~SearchResult();
 
index 57adee3f331d69768401be213e7cf726faa19c57..778c45f563bfed1e2841af321640fff80cdf7e3f 100644 (file)
@@ -40,8 +40,6 @@ class DynMessenger
 
   struct sockaddr_un d_remote; // our remote address
 
-  DynMessenger(const DynMessenger &); // NOT IMPLEMENTED
-  
 public:
   // CREATORS
 
@@ -54,6 +52,9 @@ public:
     int timeout_sec = 7,
     int timeout_usec = 0);  //!< Create a DynMessenger sending to this file
 
+  DynMessenger(const DynMessenger&) = delete; // NOT IMPLEMENTED
+  DynMessenger& operator=(const DynMessenger&) = delete; // NOT IMPLEMENTED
+
   ~DynMessenger();
 
   // ACCESSORS