]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: mc: Improve unconnected pads debugging message in link exploration
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Wed, 20 Aug 2025 14:00:21 +0000 (17:00 +0300)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Mon, 25 Aug 2025 13:40:44 +0000 (15:40 +0200)
When exploring links, a message is printed to indicate unconnected pads
being added. The message prints the entity name only. Print the origin
pad number as well to help with debugging pipeline start issues. While
at it, get the entity name from origin->entity instead of local->entity.
Both point to the same entity, but the former conveys the meaning
better.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/mc/mc-entity.c

index 307920c8b35492b2820b0daefffcfdc792c2cb96..9519a537bfa2820788de131dbcee605a1e3fa2e1 100644 (file)
@@ -682,8 +682,8 @@ done:
                return 0;
 
        dev_dbg(walk->mdev->dev,
-               "media pipeline: adding unconnected pads of '%s'\n",
-               local->entity->name);
+               "media pipeline: adding unconnected pads of '%s' reachable from pad %u\n",
+               origin->entity->name, origin->index);
 
        media_entity_for_each_pad(origin->entity, local) {
                /*