fbdev: ssd1307fb: fix potential page leak in ssd1307fb_probe()

The page allocated for vmem using __get_free_pages() is not freed on the
error paths after it. Fix that by adding a corresponding __free_pages()
call to the error path.

Fixes: facd94bc458a ("fbdev: ssd1307fb: Allocate page aligned video memory.")
Signed-off-by: Abdun Nihaal <nihaal@cse.iitm.ac.in>
Signed-off-by: Helge Deller <deller@gmx.de>

diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
index aa6cc0a8151ac09a6b10ed201b91095badd6d8e6..83dd31fa1fab538fce31c49f6658dd85dc361c9c 100644 (file)
--- a/drivers/video/fbdev/ssd1307fb.c
+++ b/drivers/video/fbdev/ssd1307fb.c
@@ -680,7 +680,7 @@ static int ssd1307fb_probe(struct i2c_client *client)
        if (!ssd1307fb_defio) {
                dev_err(dev, "Couldn't allocate deferred io.\n");
                ret = -ENOMEM;
-               goto fb_alloc_error;
+               goto fb_defio_error;
        }
 
        ssd1307fb_defio->delay = HZ / refreshrate;
@@ -757,6 +757,8 @@ regulator_enable_error:
                regulator_disable(par->vbat_reg);
 reset_oled_error:
        fb_deferred_io_cleanup(info);
+fb_defio_error:
+       __free_pages(vmem, get_order(vmem_size));
 fb_alloc_error:
        framebuffer_release(info);
        return ret;