]> git.ipfire.org Git - thirdparty/postgresql.git/commitdiff
Fix incorrectly reported stats kind in "can't happen" ERROR
authorDavid Rowley <drowley@postgresql.org>
Tue, 5 Mar 2024 03:18:19 +0000 (16:18 +1300)
committerDavid Rowley <drowley@postgresql.org>
Tue, 5 Mar 2024 03:18:19 +0000 (16:18 +1300)
The error message(s) were reporting the stats kind of 'f', which is not
correct as that's for the "dependencies" statistics kind.

Reported-by: Horst Reiterer
Reviewed-by: Richard Guo
Discussion: https://postgr.es/m/18375-ba99383eb9062d6a@postgresql.org
Backpatch-through: 12, where MCV extended stats were added.

src/backend/statistics/extended_stats.c
src/backend/statistics/mcv.c

index 91955b39c9f3012e0fec0839ba2f1e05b42b4886..4e432040977d48c53f30496626031019c8b8cf46 100644 (file)
@@ -2471,7 +2471,7 @@ statext_expressions_load(Oid stxoid, bool inh, int idx)
        if (isnull)
                elog(ERROR,
                         "requested statistics kind \"%c\" is not yet built for statistics object %u",
-                        STATS_EXT_DEPENDENCIES, stxoid);
+                        STATS_EXT_EXPRESSIONS, stxoid);
 
        eah = DatumGetExpandedArray(value);
 
index 6d9a098479d3ff55db1ac3a4632bb4e980c29f94..b7b842471e9bff736766cd31ff2218104be23dd1 100644 (file)
@@ -576,7 +576,7 @@ statext_mcv_load(Oid mvoid, bool inh)
        if (isnull)
                elog(ERROR,
                         "requested statistics kind \"%c\" is not yet built for statistics object %u",
-                        STATS_EXT_DEPENDENCIES, mvoid);
+                        STATS_EXT_MCV, mvoid);
 
        result = statext_mcv_deserialize(DatumGetByteaP(mcvlist));