]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
Describe implication of upstream ICU-22610
authorEarl Chew <earl_chew@yahoo.com>
Fri, 27 Sep 2024 13:50:31 +0000 (06:50 -0700)
committerAndrew Bartlett <abartlet@samba.org>
Fri, 8 Nov 2024 00:20:38 +0000 (00:20 +0000)
Add commentary to link commit 86c7688 (MR !3447) to the upstream
fix for ICU-22610 in case there is subsequent breakage.

Signed-off-by: Earl Chew <earl_chew@yahoo.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Nov  8 00:20:38 UTC 2024 on atb-devel-224

lib/util/charset/wscript_configure

index adae44eab5e40dbddba838b64df19f5af6d76d7a..451f7f7bca345e5b11ce036d7d380e43d631744f 100644 (file)
@@ -37,6 +37,10 @@ conf.CHECK_CODE('''
                 lib='iconv',
                 headers='errno.h iconv.h')
 
+# Since commit 86c7688 (MR !3447), the required ICU libraries are discovered
+# as a single group. This had the benefit of working around ICU-22610, and also
+# works with the fix that was merged to ICU main in commit 199bc827.
+
 if conf.CHECK_CFG(package='icu-i18n icu-uc',
                args='--cflags --libs',
                msg='Checking for icu-i18n icu-uc',