]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
misc: amd-sbi: Explicitly clear in/out arg "mb_in_out"
authorAkshay Gupta <akshay.gupta@amd.com>
Wed, 16 Jul 2025 11:07:29 +0000 (11:07 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Jul 2025 13:02:45 +0000 (15:02 +0200)
- New AMD processor will support different input/output for same command.
- In some scenarios the input value is not cleared, which will be added to
  output before reporting the data.
- Clearing input explicitly will be a cleaner and safer approach.

Reviewed-by: Naveen Krishna Chatradhi <naveenkrishna.chatradhi@amd.com>
Signed-off-by: Akshay Gupta <akshay.gupta@amd.com>
Link: https://lore.kernel.org/r/20250716110729.2193725-3-akshay.gupta@amd.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/amd-sbi/rmi-core.c

index 9048517c088c71b36ce381b259c198d45e0aae64..3dec2fc00124497ce6df74c233d35e22663818c7 100644 (file)
@@ -320,6 +320,10 @@ int rmi_mailbox_xfer(struct sbrmi_data *data,
        ret = regmap_read(data->regmap, SBRMI_OUTBNDMSG7, &ec);
        if (ret || ec)
                goto exit_clear_alert;
+
+       /* Clear the input value before updating the output data */
+       msg->mb_in_out = 0;
+
        /*
         * For a read operation, the initiator (BMC) reads the firmware
         * response Command Data Out[31:0] from SBRMI::OutBndMsg_inst[4:1]