wifi: iwlwifi: mvm: fix AP STA comparison

This should be comparing the AP STA, not the deflink firmware STA
ID. Correct the implementation so that statistics can be requested
for the AP, but not for other stations that may end up with the
firmware STA ID matching 0 in the deflink, or so.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Reviewed-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20241229164246.08b05aca37cf.Iba1a6a637a758691f710dc4f3f03bd1d960fb087@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
index 8da3616c9aeb4809ae17f5dfce794a46183e869c..5341e4ff5173a0b4f6df534a05cf9e43a79859a5 100644 (file)
--- a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
@@ -6255,7 +6255,7 @@ void iwl_mvm_mac_sta_statistics(struct ieee80211_hw *hw,
 
        guard(mvm)(mvm);
 
-       if (mvmvif->deflink.ap_sta_id != mvmsta->deflink.sta_id)
+       if (sta != mvmvif->ap_sta)
                return;
 
        if (iwl_mvm_request_statistics(mvm, false))