]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
spi: sg2044-nor: fix signedness bug in sg2044_spifmc_write()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 14 Mar 2025 10:10:15 +0000 (13:10 +0300)
committerMark Brown <broonie@kernel.org>
Sun, 16 Mar 2025 23:34:16 +0000 (23:34 +0000)
The "ret" variable needs to be signed for the error handling to work.
It should be type int, since it only holds zero and negative error
codes.

Fixes: de16c322eefb ("spi: sophgo: add SG2044 SPI NOR controller driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
Link: https://patch.msgid.link/4e16e1bf-e5fb-4771-bc92-c5cba9aac473@stanley.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-sg2044-nor.c

index 454153a63b42e6c00687d39492bd8d7bfe643d21..baa4cf67766312fddf203d527f2b3821a38eb9e8 100644 (file)
@@ -216,7 +216,7 @@ static ssize_t sg2044_spifmc_write(struct sg2044_spifmc *spifmc,
        size_t xfer_size;
        const u8 *dout = op->data.buf.out;
        int i, offset;
-       size_t ret;
+       int ret;
        u32 reg;
 
        reg = sg2044_spifmc_init_reg(spifmc);