upstream: don't leak argument list; bz3404, reported by Balu

Gajjala ok dtucker@

OpenBSD-Commit-ID: fddc32d74e5dd5cff1a49ddd6297b0867eae56a6

diff --git a/scp.c b/scp.c
index 04f1a649bcd464430bd5536700f98efbbea89918..c36d66aa59416d72495fdaecf881c902cb281e5b 100644 (file)
--- a/scp.c
+++ b/scp.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: scp.c,v 1.246 2022/02/23 19:01:00 deraadt Exp $ */
+/* $OpenBSD: scp.c,v 1.247 2022/03/20 08:52:17 djm Exp $ */
 /*
  * scp - secure remote copy.  This is basically patched BSD rcp which
  * uses ssh to do the data transfer (instead of using rcmd).
@@ -968,7 +968,7 @@ do_sftp_connect(char *host, char *user, int port, char *sftp_direct,
                        return NULL;
 
        } else {
-               args.list = NULL;
+               freeargs(&args);
                addargs(&args, "sftp-server");
                if (do_cmd(sftp_direct, host, NULL, -1, 0, "sftp",
                    reminp, remoutp, pidp) < 0)