btrfs: don't silently ignore unexpected extent type when replaying log

If there's an unexpected (invalid) extent type, we just silently ignore
it. This means a corruption or some bug somewhere, so instead return
-EUCLEAN to the caller, making log replay fail, and print an error message
with relevant information.

Reviewed-by: Boris Burkov <boris@bur.io>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c
index 21d2f3dded513b4ae8864a0a124dcd0d361a5d8c..858b609e292cb9414663a16c76b522bb788be601 100644 (file)
--- a/fs/btrfs/tree-log.c
+++ b/fs/btrfs/tree-log.c
@@ -668,7 +668,10 @@ static noinline int replay_one_extent(struct btrfs_trans_handle *trans,
                extent_end = ALIGN(start + size,
                                   fs_info->sectorsize);
        } else {
-               return 0;
+               btrfs_err(fs_info,
+                 "unexpected extent type=%d root=%llu inode=%llu offset=%llu",
+                         found_type, btrfs_root_id(root), key->objectid, key->offset);
+               return -EUCLEAN;
        }
 
        inode = read_one_inode(root, key->objectid);